Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node 4.8.2, 6.10.2 + Use gpg signature check and multi-stage build #109

Merged
merged 5 commits into from
Apr 4, 2017

Conversation

StefanScherer
Copy link
Owner

@StefanScherer StefanScherer commented Apr 1, 2017

To get rid of maintaining the sha256 checksums for each version of Node.js it would be better to use gpg signature checks as it is done for the Linux Docker images (eg. nodejs/docker-node/7.8/Dockerfile).

Install gpg on Windows isn't that easy and uninstalling the files and package would complicate the Dockerfile.

multi-stage build for the rescue

Let's try it with AppVeyor.

This is a proof-of-concept for nodejs/docker-node#362

@StefanScherer StefanScherer changed the title WIP: Use gpg signature check and multi-stage build Update Node 4.8.2, 6.10.2 + Use gpg signature check and multi-stage build Apr 4, 2017
@StefanScherer StefanScherer merged commit 34cf210 into master Apr 4, 2017
@StefanScherer StefanScherer deleted the use-gpg-for-nodejs branch April 4, 2017 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant