Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallels tools install fix when enabled in Vagrantfile #298

Merged
merged 6 commits into from
Aug 17, 2021

Conversation

earljon
Copy link

@earljon earljon commented Aug 14, 2021

No description provided.

scripts/vm-guest-tools.ps1 Outdated Show resolved Hide resolved
Copy link
Owner

@StefanScherer StefanScherer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. It needs some enhancement to make the provision script work with all Packer templates.

@earljon
Copy link
Author

earljon commented Aug 17, 2021

Hi @StefanScherer , I've updated the code to include condition to install only on Windows Server types

Copy link
Owner

@StefanScherer StefanScherer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@earljon Thank you! Now it should work on Windows 10 as well.
LGTM

@StefanScherer StefanScherer merged commit 595a0dc into StefanScherer:main Aug 17, 2021
@earljon earljon deleted the parallels-tools-fix branch August 17, 2021 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants