scrutinizer fixes

Stefanius67 · Aug 3, 2021 · c10409f · c10409f
1 parent 08c7230
commit c10409f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/SKien/XLogger/FileLogger.php b/SKien/XLogger/FileLogger.php
@@ -128,7 +128,9 @@ protected function openLogfile() : void
     {
         if ($this->logfile === false) {
             $strFullPath = $this->getFullpath();
-            switch (strtolower(pathinfo($strFullPath, PATHINFO_EXTENSION))) {
+            // scrutinizer didn't realize, that pathinfo returns allways string, if $options set!
+            $strExt = strtolower(/** @scrutinizer ignore-type */ pathinfo($strFullPath, PATHINFO_EXTENSION));
+            switch ($strExt) {
                 case 'csv':
                 case 'txt':
                     $this->strSep = ";";

diff --git a/SKien/XLogger/XLogger.php b/SKien/XLogger/XLogger.php
@@ -121,8 +121,9 @@ public function setFullpath(string $strFullpath) : void
         $this->closeLogfile();
         if (strlen($strFullpath) > 0) {
             $strFullpath = $this->replacePathPlaceholder($strFullpath);
-            $this->strPath = pathinfo($strFullpath, PATHINFO_DIRNAME);
-            $this->strFilename = pathinfo($strFullpath, PATHINFO_BASENAME);
+            // scrutinizer didn't realize, that pathinfo returns allways string, if $options set!
+            $this->strPath = /** @scrutinizer ignore-type */ pathinfo($strFullpath, PATHINFO_DIRNAME);
+            $this->strFilename = /** @scrutinizer ignore-type */ pathinfo($strFullpath, PATHINFO_BASENAME);
         }
     }
 
@@ -275,7 +276,7 @@ protected function replacePathPlaceholder(string $strPath) : string
         $strPath = str_replace('{year}', date('Y'), $strPath);
         $strPath = str_replace('{week}', date('Y_W'), $strPath);
 
-        $strUser = preg_replace("/[^A-Za-z0-9_-]/",'', $this->strUser);
+        $strUser = preg_replace("/[^A-Za-z0-9_-]/", '', $this->strUser);
         $strPath = str_replace('{name}', $strUser, $strPath);
 
         return $strPath;