Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend order info to all transactions #125

Closed
wants to merge 1 commit into from

Conversation

valentino-sm
Copy link
Contributor

  1. Fix brief order view from user.
  2. Save order_info to worker.
  3. Save worker.order_info in __order_transaction to db instead of empty row.
  4. Show order_info in full order view for admin.
  5. Hide notes if empty.

Don't use if you are not sure what you are doing.

@valentino-sm
Copy link
Contributor Author

valentino-sm commented May 7, 2021

  1. Probably we should extend db.users for order_info. Another option is loading from last transaction when worker starts. There is shipping_address in addition =D

@Steffo99 Steffo99 self-requested a review May 7, 2021 18:02
@Steffo99 Steffo99 added the feature A request for a new feature. label May 7, 2021
@Steffo99 Steffo99 self-assigned this May 8, 2021
Copy link
Owner

@Steffo99 Steffo99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is a clever idea (I never thought about storing state variables in the worker class while developing greed!), I don't really see the need to add order_info to purchase transactions, as it would be redundant and possibly inaccurate...

I'm not sure about this PR 🤔

@valentino-sm
Copy link
Contributor Author

I know this is some kind of hack but I just need the way to view order_info in-app admin-orders directly without looking into transactions.

@Steffo99 Steffo99 changed the title Full order info rebased Extend order info to all transactions May 19, 2021
@Steffo99
Copy link
Owner

Steffo99 commented Sep 4, 2021

I think I won't merge this, as it's a bit of an hack, but I'll keep your branch, since it's a good reference for implementing that feature :)

Thanks for the contribution anyways!

@Steffo99 Steffo99 closed this Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A request for a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants