-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Letterboxd: Unable to locate element: //form[@id='signin-form']//input[@id='signin-username'] #106
Comments
I did some digging around and it looks like RatS tries to login even after trying to login. The page is redirected to home page and thus cannot find the login form. Unfortunately, I do not know the code base thus cannot understand what could be causing this. |
Inserting break after this line Line 84 in 01bd362
fixes the problem. This leads to me to think that |
Letterboxd to Movielens doesn't work anyway, I guess :(
|
Hey @vn-ki RatS/RatS/letterboxd/letterboxd_site.py Line 17 in 01bd362
The standard would actually be to look for the login form elements. I see why you suspect this to be the issue and I came to the same conclusion after reading your first comment. However, after multiple runs, I couldn't reproduce the behaviour with the additional login attempt after successful login. I removed the special handling now, so the error you pasted should not occur anymore. As for the issue with the Letterboxd to Movielens migration of data, I can only say the same thing here as I already put in the console output you saw. As Movielens' own CSV Importer matches the data by IMDB id. The Alternative would be to let the script rate the movies individually (if the source does not provide sufficient data for the destination for matching movies), which will of course increase the runtime of the script significantly. I will create a separate ticket for this particular case to be considered. |
Describe the bug
Exception
Expected behavior
No excpetion
Desktop (please complete the following information):
arch
geckodriver 0.24.0
python3 transfer_ratings.py --source letterboxd --destination movielens
Stacktrace
The text was updated successfully, but these errors were encountered: