perf: improve sse message #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drop "hello" and "byebye" messages, json.loads the normal messages when using sse=True BREAKING CHANGE: The returned message type changed from str to dict re #200
Codecov Report
@@ Coverage Diff @@
## master #201 +/- ##
==========================================
- Coverage 90.79% 90.41% -0.38%
==========================================
Files 13 13
Lines 1553 1565 +12
==========================================
+ Hits 1410 1415 +5
- Misses 143 150 +7
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #201 +/- ##
==========================================
- Coverage 90.79% 90.41% -0.38%
==========================================
Files 13 13
Lines 1553 1565 +12
==========================================
+ Hits 1410 1415 +5
- Misses 143 150 +7
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drop "hello" and "byebye" messages, json.loads the normal messages when using sse=True
BREAKING CHANGE: The returned message type changed from str to dict
re #200