Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shortcuts window: double-click to execute action #1328

Closed
axd1967 opened this issue Oct 15, 2020 · 3 comments
Closed

shortcuts window: double-click to execute action #1328

axd1967 opened this issue Oct 15, 2020 · 3 comments
Labels
opinion OP thinks something should behave differently

Comments

@axd1967
Copy link
Contributor

axd1967 commented Oct 15, 2020

Is your feature request related to a problem? Please describe.
Sometimes I want to see / test what the result is of a specific action, without having to define a shortcut. The shortcuts window (F7) has a nice feature to filter for e.g. "month", which then gives all month actions:

image

Describe the solution you'd like
When I double-click on a shortcut, I would like that action to trigger. E.g. when click on "subtract one draconic month", Stellarium executes it.

This could be a controversial issue, because it is not the task of the shortcut window to do this kind of things. But I see no immediate use for a double-click in this dialog, although plenty of counter arguments could be given (e.g. reset the action to default).

Describe alternatives you've considered
Assign a shortcut, press it, reassign the shortcut to a different key, press it, etc.

Additional context
Note that the arrangement of a dialog having actionable entries is a very nice alternative to execute actions.

A similar approach works in HiPS:
(note that the user needs to check rather than double-click, but this could easily be added; in fact, there is currently a small ergonomy issue in this behaviour as the user is forced to click inside the checkbox)
image

in Oculars:
image

In sats:
image

@alex-w
Copy link
Member

alex-w commented Oct 15, 2020

Double-click in shortcut dialog is enable editor of shortcut

@alex-w alex-w added the opinion OP thinks something should behave differently label Oct 15, 2020
@axd1967
Copy link
Contributor Author

axd1967 commented Oct 15, 2020

Double-click in shortcut dialog is enable editor of shortcut

Dang - you mean this

connect(ui->shortcutsTreeView, SIGNAL(activated(QModelIndex)),
this, SLOT(switchToEditors(QModelIndex)));

Back to the drawing board.

@axd1967 axd1967 closed this as completed Oct 15, 2020
@alex-w
Copy link
Member

alex-w commented Oct 15, 2020

Yes, you mark correct LOC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
opinion OP thinks something should behave differently
Projects
None yet
Development

No branches or pull requests

2 participants