Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.21.0] Black artifacts flicker around the Sun #1581

Open
RacerBG opened this issue Apr 2, 2021 · 19 comments
Open

[0.21.0] Black artifacts flicker around the Sun #1581

RacerBG opened this issue Apr 2, 2021 · 19 comments
Labels
bug Something likely wrong in the code importance: medium A bit annoying, minor miscalculation, but no crash state: confirmed A developer can reproduce the issue

Comments

@RacerBG
Copy link

RacerBG commented Apr 2, 2021

Expected Behaviour

These artifacts appeared in version 0.21.0, they were not present in version 0.20.4.

Actual Behaviour

When zooming towards the Sun black artifacts are appearing (flicker).
Untitled

Steps to reproduce

Zoom towards the Sun.

System

  • Stellarium version: <0.21.0>
  • Operating system: <Windows 7 SP1 x64>
  • Graphics Card: <AMD Radeon R7 250 2GB>
  • Screen resolution: <1280x1024>
@gzotti
Copy link
Member

gzotti commented Apr 2, 2021

There was occasional flicker in previous versions at high zoom. However, I cannot say why.

@alex-w
Copy link
Member

alex-w commented Apr 2, 2021

Cannot reproduce on linux

@alex-w alex-w added this to To do in Visualization via automation Apr 2, 2021
@RacerBG
Copy link
Author

RacerBG commented Apr 2, 2021

There was occasional flicker in previous versions at high zoom. However, I cannot say why.

In my case, this started to happen even at moderate zoom.

Also, if this would be helpful I'm running Stellarium in standard mode (without MESA or anything like that).

@alex-w
Copy link
Member

alex-w commented Apr 2, 2021

OK, I can see artifacts on super zoom when atmosphere is enabled. Rounding issue?

@RacerBG
Copy link
Author

RacerBG commented Apr 2, 2021

OK, I can see artifacts on super zoom when atmosphere is enabled. Rounding issue?

@alex-w I did a quick test - without atmosphere everything is fine.

@gzotti
Copy link
Member

gzotti commented Apr 2, 2021

OK, I can see artifacts on super zoom when atmosphere is enabled. Rounding issue?

This is what I assumed when I saw it. But where? It is not worrying enough for me to waste a week, sorry.

It is interesting that apparently the atmosphere has the problem, and not the sun (see black polys outside the sun). Or is it during rendering the the corona or flare texture?

@alex-w alex-w added bug Something likely wrong in the code state: confirmed A developer can reproduce the issue labels Apr 2, 2021
@github-actions
Copy link

github-actions bot commented Apr 2, 2021

OK, developers can reproduce the issue. Thanks to @RacerBG for the report!

@alex-w alex-w added this to To do in OS: Windows via automation Apr 2, 2021
@alex-w alex-w removed this from To do in OS: Windows Apr 2, 2021
@alex-w
Copy link
Member

alex-w commented Apr 4, 2021

This is very interesting, but on Mac I can catch the artifacts when I switch rendering of atmosphere (on the high zoom level).

P.S. Effect is more visible near horizon - refraction/extinction issue for very bright object?

P.P.S. Effect on far planets is incredible!

@alex-w alex-w added the importance: medium A bit annoying, minor miscalculation, but no crash label Apr 4, 2021
@alex-w
Copy link
Member

alex-w commented May 20, 2021

I can see white artifacts in version 0.20.4 on the mac, so, the source of issue is deeper than we think before... :(

@alex-w
Copy link
Member

alex-w commented May 20, 2021

Apparently the issue was introduced between version 0.13.3 and version 0.14.0, because I cannot see problem in version 0.13.3, but I see it in version 0.14.0.

@gzotti
Copy link
Member

gzotti commented May 20, 2021

What effect do you see for far planets? I can see only occasional dark polys on the sun.

@alex-w
Copy link
Member

alex-w commented May 21, 2021

What effect do you see for far planets? I can see only occasional dark polys on the sun.

In version 0.21.0 I see dark polys on the Sun (see screenshots from Neptune):

stellarium-010
stellarium-015
stellarium-020

@alex-w
Copy link
Member

alex-w commented Jan 29, 2022

This is interesting: the artefacts are gone when in Skylight dialog the option "Draw Sun after atmosphere..." has been enabled. But this option introducing bug in rendering the solar eclipses, because Moon renders behind the Sun.

@gzotti
Copy link
Member

gzotti commented Jan 29, 2022

Hmm, yes I tried this mode for an exhibition in 2016 where we did not have a Solar eclipse. These are highly experimental features geared towards auto-shows where some settings may simply be controlled by the storyline.

@RacerBG
Copy link
Author

RacerBG commented Oct 2, 2022

@alex-w Update: With the ShowMySky Visual Model these weird artifacts are gone. They are still present with the default atmosphere but they are not so obvious as they used to be (I need to zoom a lot towards the sun in order to see them).

For reference this is my current configuration:

Stellarium version: <0.23.0>
Operating system: <Windows 7 SP1 x64>
Graphics Card: <AMD Radeon RX 6400 4GB>
Screen resolution: <1920x1080>

@alex-w alex-w moved this from To do to In progress in Visualization Oct 2, 2022
@alex-w alex-w added this to Needs triage in Atmosphere via automation Oct 2, 2022
@RacerBG
Copy link
Author

RacerBG commented Oct 2, 2022

Update 2: Unfortunately the performance of Stellarium with the ShowMySky Visual Model is about 2 times worse than the standard model even though I upgraded my GPU compared to my original report specs.

@gzotti
Copy link
Member

gzotti commented Oct 2, 2022

Sure, the ShowMySky is much "heavier" than the old model. There must be reasons for hi-end GPUs...

@alex-w
Copy link
Member

alex-w commented Oct 28, 2022

The center of Sun is over bright by the fact - I sees it today when atmosphere is disabled...

stellarium-035

@gzotti
Copy link
Member

gzotti commented Oct 28, 2022

That's the "halo" glow texture. If you want, remove when fov is small enough, or do some other trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something likely wrong in the code importance: medium A bit annoying, minor miscalculation, but no crash state: confirmed A developer can reproduce the issue
Projects
Atmosphere
  
Needs triage
Visualization
  
In progress
Development

No branches or pull requests

3 participants