Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trouble with selection priority of nomenclature items #239

Closed
gzotti opened this issue Jul 30, 2018 · 2 comments
Closed

Trouble with selection priority of nomenclature items #239

gzotti opened this issue Jul 30, 2018 · 2 comments
Assignees
Milestone

Comments

@gzotti
Copy link
Member

gzotti commented Jul 30, 2018

Expected Behaviour

Zoom to see Jupiter and its large moons. The moons are still tiny on screen. Click to select Io.

Actual Behaviour

If Io is deep enough in Jupiter's shadow, some named feature on Io gets selected.

This is useless. At this scale of a few pixels, the only meaningful hit should be Io. Even more so as I have disabled display of planetary nomenclature.

Probably we should first select the celestial body, and only then become "hot" for named features on this previously selected body? And with some extra penalty if named features are disabled.

Steps to reproduce

e.g. 2018-08-03 19:43:15 UT. Io is partly shadowed by Jupiter.

System

  • Stellarium version: master.16154

Logfile

Irrelevant here.

@alex-w
Copy link
Member

alex-w commented Jul 30, 2018

This behavior is useful for the Moon during lunar eclipse

@gzotti
Copy link
Member Author

gzotti commented Jul 30, 2018

Hmm, when the Moon is large enough to see detail, it may be useful. When the Moon (or Io etc.) is 5px wide, it does not make sense, really. You cannot discern Plato from Clavius. And indeed, during Friday's Lunar eclipse, named features are selected when the FoV was smaller than about 4.25 degrees, so the moon was tens of pixels in diameter and showed enough structural detail.

I think the first hit should always select the whole body, and only if that object is displayed in significant size, selection could go deeper and hit some named crater or so.

@alex-w alex-w closed this as completed in 25b4c09 Aug 4, 2018
@alex-w alex-w self-assigned this Aug 4, 2018
@alex-w alex-w added this to the 0.18.2 milestone Aug 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants