Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Satellites Plugin new clear search button continues to filter results #265

Closed
Austin-RR opened this issue Aug 26, 2018 · 1 comment
Closed
Assignees
Labels
bug Something likely wrong in the code state: confirmed A developer can reproduce the issue
Milestone

Comments

@Austin-RR
Copy link

SUMMARY

When using the new (new to 0.18.2) clear button that has been added to the Satellites Plugin for searching satellites, it appears the results will still get filtered despite the search terms getting cleared strictly by using the new clear button.

HOW TO REPRODUCE

Using "stellarium-0.18.2-win64.exe" on Windows 7 (x64):

  1. Ensure Stellarium will start with a clean startup. (%APPDATA%\Stellarium should be deleted prior to starting Stellarium.)
  2. Start Stellarium.
  3. [ALT+Z] to bring up the Satellites plugin settings and go to the "Satellites" tab.
  4. From the drop-down menu, select "all" if not already selected.
  5. All available satellites should be listed.
  6. In the search box, type "iss" (without quotes).
  7. Possibly 3 satellites should only be listed: "AISSAT 1", "ISS (ZARYA)" and "SWISSCUBE". (This is the correct behaviour.)
  • From my testing, these are the only satellites I have that include "iss" in its name.
  • Note that there may be some variations for you depending on what list of satellites are made available at the time of doing these steps.
  1. From the drop-down menu, select "scientific".
  2. Only "ISS (ZARYA)" should be listed. (This is the correct behaviour.)
  3. Use the new clear button to clear the search box.
  4. From the drop-down menu, once again select "all".
  5. Only "AISSAT 1", "ISS (ZARYA)" and "SWISSCUBE" appear in the list. (This is NOT the correct behaviour. All satellites should appear.)
  6. From the drop-down menu, once again select "scientific".
  7. Only "ISS (ZARYA)" appears in the list. (This is NOT the correct behaviour. All scientific satellites should appear.)

MORE INFO

It can be seen that every list is still being filtered with the "iss" search term despite the search box being cleared by the new clear button.

Closing the Satellites Configuration window and opening it up again does not help the issue.

The search box can be truly be cleared by manually clearing it with the delete or backspace key. If the clear button has already been used, then simply type anything in the search box and then clear it with the delete or backspace key - which is the method that has always been used before.

@alex-w alex-w self-assigned this Aug 27, 2018
@alex-w
Copy link
Member

alex-w commented Aug 27, 2018

Thank you very much for detailed bug report!

@alex-w alex-w added bug Something likely wrong in the code state: confirmed A developer can reproduce the issue labels Aug 27, 2018
@alex-w alex-w closed this as completed in 661cf07 Aug 27, 2018
@alex-w alex-w added this to the 0.18.3 milestone Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something likely wrong in the code state: confirmed A developer can reproduce the issue
Projects
None yet
Development

No branches or pull requests

2 participants