Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show arcseconds/pixel in ocular plugin #432

Closed
alex-w opened this issue Sep 26, 2018 · 10 comments
Closed

Show arcseconds/pixel in ocular plugin #432

alex-w opened this issue Sep 26, 2018 · 10 comments
Assignees
Labels
enhancement Improve existing functionality
Milestone

Comments

@alex-w
Copy link
Member

alex-w commented Sep 26, 2018

Original report by Volker H.: https://bugs.launchpad.net/stellarium/+bug/1668090

Further to Bug 1656825:

For a given sensor the published horizontal and vertical pixel sizes, resolutions und sensor dimensions often leave room for interpretation.

For example Cannon published for it's EOS600D sensor:
Chip size: 22,3 x 14,9
Resolution: 5184 x 3456
Pixel size: 4,3 x 4,3
Resolution times pixel size does not accurately match the chip size.

Proposal:
Calculate exact chip sizes from resolutions and pixel sizes.
Calculate FOV and arcsec/pixel from exact chip sizes.
Present results in Stellarium rounded to 1 digit after comma (more are meaningless).

This assures that square pixels have equal h-scales and v-scales.

@alex-w alex-w added the enhancement Improve existing functionality label Sep 26, 2018
@gzotti gzotti added this to To do in Plugin: Oculars via automation Sep 28, 2018
@crazyimp
Copy link

Isn't this solved already? The red sensor frame shows values like: 2.1434"/px in the lower right corner. Additionally, the X/Y scale are listed in the sensor selection box (top right corner).
Tested with 0.18.3.16526.

@alex-w
Copy link
Member Author

alex-w commented Jan 31, 2019

This feature request is almost done, but not complete yet.

P.S. This feature request mainly touches Oculars plugin GUI

@gzotti
Copy link
Member

gzotti commented Dec 21, 2019

@alex-w Any change?

@gzotti gzotti added the state: in progress The problem is in process of solution... label Dec 21, 2019
@alex-w
Copy link
Member Author

alex-w commented Dec 22, 2019

@gzotti not yet

@axd1967
Copy link
Contributor

axd1967 commented Jan 3, 2020

the pixel width/height values (m_pixelWidth) are not used in the code, their presence in the GUI leads to needless confusion.

consider one of following:

  • include a note in the guide that these values are currently not used
  • set the value to zero in the (copy) constructor
  • disable (grey out) or hide the input fields
  • add a tooltip or some other indication that indicates that the value is currently not active/not used/ not implemented
  • introduce a check between pixel width, chip width and X-resolution
  • if one of the three values above is cleared and the two others are available, it is calculated from the other two values

same for binning, currently not used.

@alex-w
Copy link
Member Author

alex-w commented Jul 17, 2020

Binning is used for calculation of scale, but pixel sizes are really not used. WTF?

@alex-w
Copy link
Member Author

alex-w commented Jul 17, 2020

I've checked the history changes of Oculars plugin and value of pixels size was never used. We may use it to calculate the physical size of the chip for CCD (e.g. FLI publishes the resolutions and pixel sizes for CCD's) or just remove from the GUI.

@gzotti any comments?

@alex-w alex-w self-assigned this Jul 17, 2020
@gzotti
Copy link
Member

gzotti commented Jul 17, 2020

In principle, when configuring a sensor, any change in Sensor size, pixel size and pixel count implicitly has to adapt the other two. Somehow, I think, we should therefore configure one of the three to "auto". Whether as global switch or as per-sensor value, I don't care.

I have wondered for years why this has been introduced but never activated. Presumably no developer has enough time to fulfill his dreams :-), and currently I have no need to configure sensor pixel sizes :-(

There are some further technical issues with the whole plugin.

  • Get rid of QSignalMapper (to prepare for Qt6)
  • Fix what I had tried a year ago (interactive scaling of sensor frame and OAG by mouse wheeling the spinners worked already, but somebody complained it inhibited his manual entering of numbers (decimal point?). You fixed that, somehow, but in a way I'd like to see changed: Now you can enter numbers (pressing Enter), but when using the spinner/mousewheel they don't become immediately effective (You must press Enter or switch to another spinner to see effects of the change!), causing questions as to how to use OAG settings, which I had regarded extremely intuitive with the spinners working properly.) There are too many ways and dissenting preferences to operate GUI elements, it seems.

@alex-w alex-w added this to the 0.20.3 milestone Jul 17, 2020
@alex-w alex-w closed this as completed in 898495d Jul 17, 2020
Plugin: Oculars automation moved this from To do to Done Jul 17, 2020
@alex-w alex-w removed the state: in progress The problem is in process of solution... label Jul 17, 2020
@alex-w
Copy link
Member Author

alex-w commented Jul 17, 2020

I've removed pixel size

@alex-w
Copy link
Member Author

alex-w commented Jul 18, 2020

Please check version 0.20.2.18074

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality
Projects
Development

No branches or pull requests

4 participants