Subtract store credit from total sent to PayBright #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alepore
reviewed
Aug 16, 2017
| @@ -15,7 +15,7 @@ def build_redirect_params | |||
| params = { | |||
| # mandatory parameters | |||
| "x_account_id" => credentials[:api_key], | |||
| "x_amount" => order.total.to_money.to_s, | |||
| "x_amount" => (order.total - order.total_applicable_store_credit).to_money.to_s, | |||
There was a problem hiding this comment.
Minor: i see there's an Order#order_total_after_store_credit method
luukveenis
force-pushed
the
handle-store-credit
branch
from
8437ba9
to
e2518aa
Compare
Since PayBright doesn't allow us to modify payments before capturing them like some other payment methods, we need to ensure we send them the correct amount right away.
luukveenis
force-pushed
the
handle-store-credit
branch
from
0ff986a
to
7a47ec0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PayBright doesn't allow us to modify payments before capturing them like some other payment methods, we need to ensure we send them the correct amount right away.