Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop onClick event propagation from TextInputButton #727

Merged

Conversation

mattias800
Copy link
Collaborator

Stop onClick event propagation from TextInputButton, so keyboard navigation on button does not affect text input (or in extension, forms).

Keyboard interaction with TextInputButton could trigger form submit.

… on button does not affect text input (or in extension, forms).
@mattias800 mattias800 added bug Something isn't working patch Increment the patch version when merged labels Mar 25, 2024
Copy link

Size Change: 0 B

Total Size: 358 kB

ℹ️ View Unchanged
Filename Size
packages/calendar/dist/index.es.js 15.2 kB
packages/calendar/dist/index.js 12.7 kB
packages/core/dist/index.es.js 5.23 kB
packages/core/dist/index.js 4.77 kB
packages/elements/dist/index.es.js 100 kB
packages/elements/dist/index.js 97.8 kB
packages/filter/dist/index.es.js 3.65 kB
packages/filter/dist/index.js 3.02 kB
packages/forms/dist/index.es.js 8.37 kB
packages/forms/dist/index.js 7.61 kB
packages/grid-export/dist/index.es.js 1.89 kB
packages/grid-export/dist/index.js 1.79 kB
packages/grid/dist/index.es.js 24.8 kB
packages/grid/dist/index.js 20.6 kB
packages/input-mask/dist/index.es.js 714 B
packages/input-mask/dist/index.js 614 B
packages/modal/dist/index.es.js 6.22 kB
packages/modal/dist/index.js 5.59 kB
packages/panels/dist/index.es.js 7.12 kB
packages/panels/dist/index.js 6.19 kB
packages/redux/dist/index.es.js 2.93 kB
packages/redux/dist/index.js 2.62 kB
packages/select/dist/index.es.js 4.49 kB
packages/select/dist/index.js 3.85 kB
packages/theme/dist/index.es.js 2.01 kB
packages/theme/dist/index.js 2.05 kB
packages/tooltip/dist/index.es.js 2.88 kB
packages/tooltip/dist/index.js 2.61 kB

compressed-size-action

@AugustasFriend AugustasFriend self-requested a review March 25, 2024 14:42
@mattias800 mattias800 merged commit 1dc2a9f into master Mar 25, 2024
6 checks passed
@mattias800 mattias800 deleted the feature/text-input-button-should-not-propagate-events branch March 25, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch Increment the patch version when merged
Projects
None yet
2 participants