포트폴리오 Batch Insert 및 Update 구현하기 #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 17, 2023 15:21
- 포트폴리오 서비스 로직: 가격 일괄 등록 로직 수정 - PriceItem JDBC Repository 추가 - PriceItem JDBC Batch Insert Impl
- 포트폴리오 이미지 서비스 로직 수정: saveImage를 batchInsert 로직으로 - JDBC Template을 활용한 ImageJDBCRepository 인터페이스, ImageJDBCRepositoryImpl - 이미지 업데이트는 삭제, 메서드화 되어있으므로 알아서 같이 구현되었음
- 포트폴리오 가격 batch insert 구현 - 주석 달음
chaee813
reviewed
Oct 17, 2023
| String sql = "INSERT INTO imageitem_tb (portfolio_id, origin_file_name, file_path, file_size, thumbnail) VALUES (?, ?, ?, ?, ?)"; | ||
|
|
||
| jdbcTemplate.batchUpdate(sql, imageItems, imageItems.size(), | ||
| (ps, priceItem) -> { |
There was a problem hiding this comment.
동작에는 문제가 없지만 이 부분 imageItem 아닐까요!? 이것만 따로 PR 날리기 귀찮으실 것 같아서 수정하고 푸시 해주시면 머지하겠습니다! 구현하시느라 고생하셨어요!! :)
There was a problem hiding this comment.
@chaee813 앗 오타를 내버렸네요, 수정했습니다. 감사합니다 !!
- ImageItemJDBCRepositoryImpl.java에 있는 오타 수정 - priceItem -> imageItem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
application-local.yaml파일에 다음 설정 필요