-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
가격 기반 포트폴리오 필터링 구현 및 에러 수정 #115
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 포트폴리오 견적가에 따른 필터링 구현
- 테스트용 포트폴리오 데이터 수정
- 토큰 에러 발생 시, 에러 메시지가 중복되는 문제 해결
- 플래너를 join하지 않아 발생하는 데이터베이스 오류 수정
- 리프레시 토큰 에러가 발생해도 진입 성공하는 오류 수정
- 에러 메시지가 중복되어 출력되는 버그 수정
- 포트폴리오 조회 시 커서의 디폴트 값 추가 - 커서의 키 유효성 검증 메서드에서 키 값이 NONE_KEY보다 크도록 수정
# Conflicts: # sunsu-wedding/src/main/java/com/kakao/sunsuwedding/portfolio/PortfolioService.java # sunsu-wedding/src/main/resources/db/teardown.sql
- Specification에서 planner 테이블을 항상 join 하여 탈퇴한 플래너인지 체크하도록 변경 - Specification에서 필터링 옵션 확인을 하므로 서비스 로직에서 검증 로직 삭제
chaee813
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
시험기간이신데도 엄청 수정 많이 하셨네요...! 고생 많으셨습니당!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
이슈 번호
close #107
close #108
close #109