Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chat, Match 엔티티 분리 #123

Merged
merged 11 commits into from
Oct 26, 2023
Merged

Chat, Match 엔티티 분리 #123

merged 11 commits into from
Oct 26, 2023

Conversation

chaee813
Copy link
Contributor

한 일

  • Chat 엔티티에 채팅방 생성 기능 생성
  • Match 엔티티에는 전체 견적서 확정 기능만 남기기
  • matchId에서 chatId로 파라미터 이름 일괄 변경
  • 분리된 엔티티에 맞게 테스트 코드 분리

TO DO

  • ChatJPARepository 테스트 코드 작성

close #85

@chaee813 chaee813 added enhancement New feature or request Done 진행 완료 refactor match 매칭내역 관련 기능 labels Oct 25, 2023
@chaee813 chaee813 self-assigned this Oct 25, 2023
1jeongg
1jeongg approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@1jeongg 1jeongg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chat도 잘 분리되었고 pathVariable도 matchId에서 chatId로 잘 바꾸어주셨네요!!
고생하셨어요 ㅠㅠ
아 근데 앞으로도 사용하지 않을 것 같은 코드는 주석보다는 삭제해도 괜찮을 것 같아요! history는 다 남아있으니까요!

@1jeongg 1jeongg merged commit 45a7ec1 into Step3-kakao-tech-campus:weekly Oct 26, 2023
1 check passed
@chaee813 chaee813 deleted the feat/chat-yc branch October 31, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1jeongg 1jeongg 1jeongg approved these changes

Assignees

@chaee813 chaee813

Labels
Done 진행 완료 enhancement New feature or request match 매칭내역 관련 기능 refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chat, Match 엔티티 분리
2 participants
@chaee813 @1jeongg