-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
커서 기반 페이지네이션, refresh token 구현 #91
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 추가 쿼리를 방지하기 위해 엔티티 그래프 추가 - 리팩토링 : DTO 이름 변경, 중복 메서드 제거
- 견적서에서 match 필드에 lazy loading 적용 - 견적서 업데이트 흐름 수정 - ImageItem 에서 중복 join되는 오류 수정
- 포트폴리오 리스트 조회를 커서 기반 페이지네이션으로 구현
- 기능에 따라 코드 분리
- 테스트용 데이터 추가
# Conflicts: # sunsu-wedding/src/main/java/com/kakao/sunsuwedding/match/Quotation/QuotationService.java # sunsu-wedding/src/main/java/com/kakao/sunsuwedding/portfolio/image/ImageEncoder.java
- 충돌 수정
- 토큰을 위한 엔티티, 저장소, 서비스 로직 생성
- refresh token 구현
- refresh token 추가로 변경된 로직 반영
- 커서가 끝을 가리킬 경우 -2 를 가리키기 때문에 컨트롤러의 커서 값의 최소 값을 -2로 변경
- access token 만 가지고 갱신 요청 시 발생하는 데이터베이스 오류 해결 - 코드 리팩토링
chaee813
approved these changes
Oct 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
바꿀 게 많아서 복잡하셨을텐데 고생 많으셨습니다!!!
완전 실력자시네요 , , , 👍
chaee813
reviewed
Oct 14, 2023
} | ||
|
||
// transcation 을 열어야 할 것 같은데 | ||
// 접근 제한자를 protected 에서 public 으로 바꿔야 합니다...!! | ||
// 바꿔도 괜찮을까요 ..??? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@1jeongg 머지하긴 했는데 이 부분은 원정님이 답변해주시면 좋을 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
주의 사항(Optional)
이슈 번호
close #86
close #87