Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

포트폴리오 평균 거래가격 계산 로직 수정 #94

Merged
merged 3 commits into from
Oct 14, 2023
Merged

포트폴리오 평균 거래가격 계산 로직 수정 #94

merged 3 commits into from
Oct 14, 2023

Conversation

chaee813
Copy link
Contributor

@chaee813 chaee813 commented Oct 14, 2023 •
edited
Loading

한 일

  • PriceCalculator의 avgPrice 계산 메서드 내에 divide by zero 문제 해결
  • 탈퇴한 플래너의 포트폴리오 id로 조회 시 예외 처리

close #93

@chaee813 chaee813 added Done 진행 완료 portfolio 포트폴리오 관련 기능 refactor labels Oct 14, 2023
@chaee813 chaee813 self-assigned this Oct 14, 2023
1jeongg
1jeongg approved these changes Oct 14, 2023
View reviewed changes
Copy link
Member

@1jeongg 1jeongg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨어요!! 👍👍

@1jeongg 1jeongg merged commit e3fea4b into Step3-kakao-tech-campus:weekly Oct 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1jeongg 1jeongg 1jeongg approved these changes

Assignees

@chaee813 chaee813

Labels
Done 진행 완료 portfolio 포트폴리오 관련 기능 refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

포트폴리오 평균 거래가격 계산 로직 수정
2 participants
@chaee813 @1jeongg