채팅방 생성 API 수정 및 테스트 코드 추가 #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- null에서 chatId를 반환하도록 변환 - 플래너와 예비 부부 사이에 하나의 매칭 내역만 존재하도록 변경
- add할 때 Transaction 걸어주기 - BadRequest 에러 메시지 404 -> 400
- sql파일: order_id와 payment_amount 추가, match_tb id가 2부터 시작 - dummyEntity: 비활성화된 플래너, 새로운 Match, 새로운 Token 추가
chaee813
approved these changes
Oct 14, 2023
| @@ -14,4 +14,7 @@ public interface MatchJPARepository extends JpaRepository<Match, Long> { | |||
|
|
|||
| @Query("select m from Match m where m.planner = :planner and m.confirmedAt != null order by m.confirmedAt desc limit 10") | |||
| List<Match> findLatestTenByPlanner(@Param("planner") Planner planner); | |||
|
|
|||
| @Query("select m from Match m where m.planner = :planner and m.couple = :couple") | |||
| List<Match> findByCoupleAndPlanner(@Param("couple") Couple couple, @Param("planner") Planner plannerId); | |||
There was a problem hiding this comment.
별 거 아니긴 한데 Planner 뒤에 plannerId 말고 planner 라고 하려고 하셨던 거 아닌가욧!?
There was a problem hiding this comment.
헉 고치다가 잘못썼네요 ㅠㅠ 나중에 수정하겠습니다!
|
테스트 케이스 이렇게 꼼꼼하게 짜주시다니.. 고생 많으셨겠어요 ㅠㅠ!! 짱짱 수고하셨습니다!! 👍👍 |
|
아 그리고 id 1부터 있을 때 에러 나는 건 여기 참고하시면 될 것 같아요! @ ActiveProfiles는 이미 붙어있어서 application-test.yml 파일만 2단계 때 쓰던 거 그대로 들고 오니까 Auto-increment 적용되고 teardown.sql에 있는 값들의 다음 id부터 생기네욥!! |
|
헉 참고 블로그까지 ㅠㅠ 알려주셔서 감사합니다!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
Todo
Dataintegrityviolationexception에러가 발생한다. -> 멘토님께 질문하기close #89