Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cp interface function #433

Closed

Conversation

schwiti6190
Copy link

@schwiti6190 schwiti6190 commented Mar 26, 2022

Added interface function for cp stonepickers.

@Axel32019
Copy link
Collaborator

Hello @schwiti6190 ,
The Event onCpFuelEmpty is not really useful as it is invoked by isFuelEmpty at FillLevel == 0, better to invoke from isFuelLow(0.1)
Event onCpBroken would be good to raise on damage level >60% at vehicle or at least 1 attached implement.

@schwiti6190
Copy link
Author

Hi @Axel32019
If you implement these events, than I would add two setting for the user to configure the threshold for releasing of the driver.

Axel32019 added a commit that referenced this pull request Apr 10, 2022
@Axel32019
Copy link
Collaborator

@schwiti6190 The events are added with above commit, "fake" tests where OK so far.

@schwiti6190
Copy link
Author

@Axel32019 perfect will implement this in cp then.

@Iwan1803
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants