Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional entities for Deye_2mppt #285

Merged
merged 2 commits into from
May 9, 2023

Conversation

haraldfunk
Copy link
Contributor

Compared to the stock solarman app the deye_2mppt.yaml file lacked a lot of information.

I added a lot additional information after looking up the register contents and compared them to the values shown in solarman app.

Additional Information:

  • Daily Production 1
  • Daily Production 2
  • Total Production 1
  • Total Production 2
  • Active Power Regulations
  • Grid Current
  • Grid Voltage Upp Limit
  • Grid Voltage Lower Limit
  • Grid Frequency Upper Limit
  • Grid Frequency Lower Limit
  • Overfrequency And Load Reduction Starting Point
  • Overfrequency And Load Reduction Percentage
  • ON-OFF Enable
  • Island Protection Enable
  • Overfrequency&Load-shedding Enable
  • Hardware Version
  • DC Master Firmware Version
  • AC Version Number
  • Rated Power
  • Communication Protocol Version
  • Start-up Self-checking Time
  • Update Time
  • Soft Start Enable
  • Power Factor Regulation
  • Restore Factory Settings

To parse the version and datetime information in the registers, i also added some additional rules:

  • 7: try_parse_version
  • 8: try_parse_datetime

Most (if not all) additional parameter should also work identically for Deye_4MPPT devices, but would need to be tested.

@CarstenGrohmann
Copy link
Contributor

What do you think about renaming "Daily Production" to "Daily Production (all strings)" and "Total Production" to "Total Production (all strings)"?

@StephanJoubert StephanJoubert merged commit 4cc988b into StephanJoubert:main May 9, 2023
2 checks passed
@b-reich
Copy link

b-reich commented Jun 29, 2023

@StephanJoubert can u please release this? This would be awsome

@b-reich
Copy link

b-reich commented Jun 29, 2023

@haraldfunk does this also work with the SUN-M80G3-EU-Q0? It also have 2 MPPT.
Edit: yes

@gersko
Copy link

gersko commented Jun 29, 2023

@haraldfunk Shouldn't the following parameters also have validation: min: 0.1 added, like Total Produktion?

  • Total Production 1
  • Total Production 2
  • Daily Production
  • Daily Production 1
  • Daily Production 2

@gersko
Copy link

gersko commented Jun 29, 2023

Also, IMO to stay consistent with the rest of the parameters, Total Production 1, Total Production 2, Daily Production 1 and Daily Production 2 should be renamed to PV1 Total Production, PV2 Total Production and so on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants