ci: Fix cancelation of Docker builds in CI #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Docker publication workflow tries to optimize and avoid rebuilding GCC if nothing has changed. However, the very first workflow run that should have created the very first GCC Docker image was canceled. This changes the concurrency setting on the workflow so that it does not cancel an existing workflow. This way, if a series of changes are merged rapidly, and an earlier one requires a GCC rebuild, the later workflow runs will see that image. This allows us to keep the optimization of skipping GCC rebuilds most of the time.
|
Canceled build, for reference: https://github.com/Stephane-D/SGDK/actions/runs/9180679521 |
Stephane-D
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Docker publication workflow tries to optimize and avoid rebuilding GCC if nothing has changed. However, the very first workflow run that should have created the very first GCC Docker image was canceled.
This changes the concurrency setting on the workflow so that it does not cancel an existing workflow. This way, if a series of changes are merged rapidly, and an earlier one requires a GCC rebuild, the later workflow runs will see that image.
This allows us to keep the optimization of skipping GCC rebuilds most of the time.