New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit tests needed #162
Comments
Unit tested Tile.java class and created PR for it (see #164) |
Thanks for contribution! Hope it will be accepted. In order to improve code quality, I'd remove test word from method name (it is redundant) and use a self explaining format like
Look here for some examples https://medium.com/@stefanovskyi/unit-test-naming-conventions-dd9208eadbea |
@redcloud80 thanks for the additional reading material, I'll have your note in mind when naming other test methods in the future (as I find getters test names to be self-explanatory). |
Classes that need to be covered with a first unit test iteration: PLEASE RESERVE A TASK IN ORDER TO AVOID CODING TASK OVERLAPPING BETWEEN DEVELOPERS.
|
At this stage your time would better spent developing the game, rather than adding tests. |
I will for sure but testing is something that shouldn't be separated from feature implementation. I wouldn't release new features with no tests. |
Hello, can I contribute to this project with writing tests ? |
Hi, which class would you like to take care of? Open a specific issue for the task please. |
We should add unit tests for existing codebase in order to have a coverage of 80% at least.
The text was updated successfully, but these errors were encountered: