Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples - Support for react-dnd 9.4.0 #163

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chaitan94
Copy link

As you may know react-dnd recently dropped the DragDropContext component [1], and introduced DndProvider [2]. This pull request makes the necessary changes to accommodate for that. This should also hopefully address some open issues like #146 and #147.

[1] react-dnd/react-dnd#1439
[2] https://react-dnd.github.io/react-dnd/docs/api/dnd-provider

@andrisundae
Copy link

I just installed your library and use DragDrop.js example...But i still have issue like this...i also try change this withDnDcontext.js
image

@chaitan94
Copy link
Author

@andrisundae can you give more details? Do you mean to say you are facing this issue even after working on top of my commit? Could you share the exact version of react-dnd which is being used in your project?

@andrisundae
Copy link

@chaitan94 Thank u, i just installed React CRA and add react-dnd@9.4.0, react-big-scheduler new version for depedencies...And use withDnDContext.js from your last commit...
But i still facing this issue...
If i clone this library and running for locally i'am not facing this issue again...
Please help me..thank u..

@tannerhallman
Copy link

tannerhallman commented Nov 19, 2019

I also can confirm I was getting the same issue as @andrisundae. I used the Basic.js example from this repo to try it. For reference, I was working with react-big-scheduler@0.2.7 and then I downgraded to react-big-scheduler@0.2.6 and it worked with your changes listed below:

withDnDContext.js

/* eslint-disable react/display-name */
// import { DragDropContext } from 'react-dnd'
// import HTML5Backend from 'react-dnd-html5-backend'

// export default DragDropContext(HTML5Backend)

import * as React from 'react'
import { DndProvider } from 'react-dnd'
import HTML5Backend from 'react-dnd-html5-backend'

export default Component => {
  return props => (
    <DndProvider backend={HTML5Backend}>
      <Component {...props} />
    </DndProvider>
  )
}

package.json

    "react-dnd": "^9.4.0",
    "react-dnd-html5-backend": "^9.4.0",
    "react-big-scheduler": "^0.2.6",

@alizaidi606
Copy link

@chaitan94 have you published your version of this library to npm?

@chaitan94
Copy link
Author

@chaitan94 have you published your version of this library to npm?

No, I haven't.

@alizaidi606
Copy link

alizaidi606 commented Jun 3, 2020

@chaitan94 I am trying to publish this to npm by cloning from your repo the one with the pull request but am having issues while building package.
That issue is also mentioned on this latest issue #201

\react-big-scheduler\react-big-scheduler\scripts\build.js:11
throw err;
^

TypeError [ERR_INVALID_ARG_TYPE]: The "chunk" argument must be of type string or an instance of Buffer. Received an instance of Error
at validChunk (_stream_writable.js:279:10)
at WriteStream.Writable.write (_stream_writable.js:314:21)
at build (\react-big-scheduler\react-big-scheduler\scripts\build.js:70:20)
at processTicksAndRejections (internal/process/task_queues.js:97:5)
Emitted 'error' event on WriteStream instance at:
at errorOrDestroy (internal/streams/destroy.js:108:12)
at validChunk (_stream_writable.js:282:5)
at WriteStream.Writable.write (_stream_writable.js:314:21)
at build (\react-big-scheduler\react-big-scheduler\scripts\build.js:70:20)
at processTicksAndRejections (internal/process/task_queues.js:97:5) {
code: 'ERR_INVALID_ARG_TYPE'
}
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! react-big-scheduler@0.2.9 build: node scripts/build.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the react-big-scheduler@0.2.9 build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:

@massile
Copy link

massile commented Dec 24, 2020

Is there any updates regarding this issue? I still have the same issue with the newer version of react-big-scheduler (0.2.7)

@beysong
Copy link

beysong commented Jan 6, 2022

I have update antd to 4.x and react-dnd to 14.x, but in my forked respository https://github.com/StephenChou1017/react-big-scheduler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants