Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Backend.OpenXR.EyesSampleTime #358

Merged
merged 9 commits into from
Apr 8, 2022

Conversation

sandrist
Copy link
Contributor

@sandrist sandrist commented Apr 8, 2022

Addresses Issue #356

OpenXR provides the ability to query the actual device sample time associated with a given gaze tracker result. This PR surfaces that information so it is accessible in StereoKit.

  • Created a separate openxr_get_gaze_space() method that is similar to the existing openxr_get_space() but fills in the extra timing information specific to gaze.
  • Added Backend.OpenXR.EyesSampleTime for querying that sample time.
  • Added an example of how to use this information in the existing DemoEyes.cs. The sample time is used to determine and display the true sampling frequency of the gaze tracker.

@maluoi
Copy link
Collaborator

maluoi commented Apr 8, 2022

GitHub is reporting a conflict here (blocking merge). But other than that, everything looks good!

@maluoi maluoi merged commit 12fce24 into StereoKit:develop Apr 8, 2022
@maluoi
Copy link
Collaborator

maluoi commented Apr 8, 2022

Okay, nevermind, that was just the rebase option! Thank you! :)

@sandrist sandrist deleted the feature/eyes_sample_time branch April 8, 2022 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants