applying dynamic attribute name has no effect in ie6-7

[SteveSanderson]

if in binding we have attr: { name: 'cb' + Propery()}
it will not have effect in ie6-7. similar bug #197
was fixed for unique name

[SteveSanderson]

Agreed we fix this (the fix is to use mergeAttributes I guess - I'm happy to do it, as with any of the other fixes)

[SteveSanderson]

Yahuen, could you clarify in what way this isn't already supported? I've added a spec (see above) to show this working, and it already passes on IE6. What aspect of setting the name attribute doesn't work - can you provide sample code?

[mbest]

Steve, if it already works for attr/name, why would uniqueName need a workaround?

Here's some info about how to reproduce the problem: http://webbugtrack.blogspot.com/2007/10/bug-235-createelement-is-broken-in-ie.html

[mbest]

I modified the new spec to show how it fails in IE6.

actual value:
"<INPUT data-bind='attr: { name: "newName" }' __ko__1341311374578="ko3">"

should match with pattern:
"name="?newName"?"

[SteveSanderson]

Ah yes, I remember! Thanks for clarifying.

[mbest]

This looks good. I've added a small change that fixes #452. Without the fix, the new spec will fail in IE9 with browser mode = IE9 Compatibility View and document mode = IE9 Standards. Ready to merge.

[SteveSanderson]

Thanks! Merged.

At some point we might want to consider moving to feature detection for these kinds of things (to avoid having to know about IE compat modes). There is a tradeoff, though, is it will probably be a fair bit of extra code to do it that way. For now this is great as-is.

[mbest]

I too was thinking that this would be a good candidate for feature detection. Thanks for taking care of this.