New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hoping you could add these... #1661
Comments
Hello! Thank you for opening your first issue in this repo. It’s people like you who make these host files better! |
@StevenBlack, how do you verify these actually unwanted sites? Any tests? Just curious to this whole process Thanks for making my life better |
@bnainar I think there's too much for a single person to verify every single entries, I propose those because of my own testing, and personally added those to my pihole's blacklist and hoping others that uses this list could benefit from it. I sure hope the community could prove me wrong on those urls |
Hi Nainar @bnainar, Mostly I rely on curators who've been regularly maintaining their own lists for a long time. For ad-hoc additions like those in commit 7ad72d7 I typically check several things.
Often it's just instinct 😄 |
Just ran into legit videos being blocked by Not sure what your process is for reviewing things like this, but it is blocking legit videos in at least one app. I've added it to my white list for now, and maybe it is something I should address with the developers of the app, I assume they are unaware they are sharing a domain with people hosting video ads. |
Hi Zachary @zchrykng thank you for your observation. To clarify, it doesn't matter if legit videos — however that's defined — are blocked. If the domain vehicles their users, or other scam behavior, then it's blocked. Sometimes sites use scam behavior as a prerequisite for providing service. For example, we all could say "legit website x blocks me because of my ad blocker." Our purpose is preventing scam behavior. |
Acknowledged. I will reach out to the developers of the app that is being impacted. The videos that are being blocked aren’t ads and the site as a whole still functions, just the cdn they are using for their own videos appears to be black holed by this rule. If it would be possible to get information about the bad stuff coming from the same domain, I would appreciate it for when I talk to them. |
Okay, removing this comment for now. Doing some more digging into exactly what is happening with this app. The videos aren't hosted here, so I'm unsure why the domain is being hit. |
@zchrykng jwpsrv.com seems like part of jwplayer.com, if you study jwplayer.com it says "Maximize Ad Revenue". I would normally go for (.|^)jwpsrv.com as some app shows unwarranted videos during an article read, and it's damn annoying. |
Thank @piengeng, good info. I know they aren’t trying to monetize this, might just be an issue with the configuration or possibly they are using it for analytics. |
This is all-good Zachary @zchrykng. Maybe listing |
I'm not aware of specific apps that are serving ads using this package. The app I know that was being impacted definitely isn't serving ads this way. I'm not sure how to check the connections that iOS apps are making though. Only way I was able to identify the issue was looking at my pihole logs. |
now i'm interested haha, Zachary, can you share what's the mentioned iOS app? and what sites are your visiting using the app? I don't own apple product, but recent apple's ad on tracking prevention on iOS at https://youtu.be/8w4qPUSG17Y is super interesting, maybe i'll find the same app for android and play around... no promises.. |
The |
Steve @StevenBlack i can confirm that,maybe is for the best to remove it from here. |
LE, I've tried whitelisting the two videos*.jwpsrv.com, the video is still blocked, this is some magic trick by jwplayer haha, my guess it's something else... the plot thickens
|
i think space.com is trying to monetize videos published by NASA https://www.nasa.gov/feature/goddard/2020/4000th-comet-discovered-by-esa-nasa-solar-observatory using jwplayer's ad solution, nevertheless, i respects Steven's work and his decision. pihole is super great, I'll keep videos-*.jwpsrv.com in my blacklist. |
It is Bible Stories for the Young android version is here I was in contact with them last night and it appears that a support request to jwplayer changed the url they are hitting, but it is still blocked by another rule. The new url is videos-cloudflare.jwpsrv.com. |
@piengeng this is the whole link that it's blocked: EDIT: I can confirm after removing the domain.clearing out the cache,video got stuck playing the first time but after refreshing the page it was all good !!! |
@dnmTX yup you're right, it might be too broad, as jwpsrv is serving both videos ads and videos created by others. |
Thanks everybody, so what's the consensus? What's best? Remove |
think is both |
We block domains that do tracking and is adware. If we apply the same logic, we may not be able to see YouTube videos |
👍 P.S. Thanks to @llacb47 for finding a link so can be examined. Steve @StevenBlack i thought you decided not to add anything without context? Stick to it,please 🙏 |
after some soul-searching.. I'd like to stand my ground and explain why I think it's best to keep these 2 urls. I think it's a selfish and naive argument, and at the expense of everyone else's internet experience. I think whoever that wish to see ads/videos hosted by if every apps/sites that breaking because we stand our ground. it's wishful thinking, maybe they'll separate out legit vs ads videos, eventually, it might be those kind of social experiment like gamestop/bitcoin. How about we wait for a month or a year? see if there's any more feedbacks from at least some percentage out of 18k starred individuals? unless some conspiracies like jwplayer pays microsoft/github to remove this repo... because it affects their bottomline. |
you know I'm perfectly fine if jwpsrv.com reach out to Steven and offer him a couple of millions USD or few bitcoins just to remove these 2 urls. maybe also the very first original entry |
My biggest objection to this take is that these are broad enough to be catching services that are doing literally zero advertising. Concerned that someone less technical than us is going to run into videos they actually want to see being blocked and be unable to diagnose what is going on. |
Dan @dnmTX my problem is, I don't use this video service so I can't judge. I also have limited bandwidth to devote to this particular issue. I just want to know the final recommendation, one way or another. |
Apparently the University I'm affiliated with uses this service to host lectures. Due to the Adding this information as an example of a legit use-case impacted by the filter. |
Yes, I think that it should be removed. I don't agree with @piengeng's reasoning
As three different people in this thread have shown, the domain is not exclusively used for ads. It's a CDN for JWPlayer customers. Another video that's broken: |
@rkuijt you're just the right person for me to ask this, out of curiosity, I'm wondering if jwpsrv.com is owned by jwplayer.com, the university is paying according to https://www.jwplayer.com/tos/ "License Scope" ? I'm just curious about the definition of adware. reminds me of duck-typing. what i'm trying to say is, logically if it's considered adware, then it should be kept, if not, it should be removed, so maybe i'm trying to switch the discussion to how adware is defined. |
Yes
|
LongTail Ad Solutions. Inc. yeah i read it in wikipedia, turns out there's some history related to youtube as well, no wonder the mentions. Anyone propose |
Thanks everyone for all your input. I just merged #1665. Ultimately Pull Requests speak 😄 |
@StevenBlack yup ultimately the entity with the most to lose, aka, the advertising company, wins, the pull request is from people close to jwplayer.com . cdn serves ads too.. |
Hey @piengeng, I think there is a fundamental misunderstanding of JW Player here. While some JW customers use the platform for serving ads, or monitoring their videos - the JW service provided via those domains are mostly for serving video content. Would you want to block all AWS domains? Probably not. As it turns out, the majority of end-users who were affected by the addition of the two domains were students trying to watch education video content. If you have any other concerns, please feel free to reach out to me - happy to have a conversation offline to address any concerns you have. |
@SageBrushes If jwplayer customer is paying jwplayer, isn't it a better if you separate out CDN, with the resources and money, jwplayer cannot separate the CDN between university usage and your commercial usage? Are you kidding me, I'm not sure why you want to give such an excuse. I find it hard to believe of what you're saying, and having big corporation to decides how community adblocker works, and never contribute in discussion and directly say it's a bug and cheeky pull request stunt. I pray that you compensate fairly to the owner of this project. |
@piengeng what may seem like a simple feature request may actually be a fundamental change in a platform architecture. As you progress in your career you will be on the other side of this type of feature request conversation and laugh at his thread. |
@SageBrushes well put, the most perfect ad platform that cannot be changed. |
@piengeng I can't provide any insights regarding contractual agreements between the university and JW Player. But even if I could, such information would probably be prohibited for public disclosure. Regardless, I'll happily provide a bit of context which might help to put your discontent into perspective. From this perspective, software like freeware or websites which operate on ads do not fall into the adware category. Then there's JW Player. As far as I have distilled from their website they provide businesses the service to manage content through their CDN. Allowing organizations to focus on their primary business instead of having to maintain a media player and distribution platform. In addition, they seem to offer a feature so their customers can monetize their own content by displaying ads. Unfortunately blocking these services through DNS is not the solution as it renders the whole service unusable. There are other solutions like DOM filtering or dynamic content analysis which try to identify ads by other means and might be better suited for this kind of advertisement blocking. Hopefully this provides you some perspective 😉 [1] https://www.kaspersky.com/resource-center/threats/adware |
please whitelist invol.co |
0.0.0.0 xvtelink.com # ads with redirects
0.0.0.0 invol.co # tracking
0.0.0.0 36c4.net # redirect to go.trafficrouter.io
0.0.0.0 go.trafficrouter.io
0.0.0.0 track.venatusmedia.com # tracking
0.0.0.0 amptrack.dailymail.co.uk # tracking
0.0.0.0 mailmetromedia.amp.permutive.com #ad
0.0.0.0 videos-cloudflare.jwpsrv.com # video ads
0.0.0.0 videos-fms.jwpsrv.com # video ads
The text was updated successfully, but these errors were encountered: