Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updateHostsFile.py fails to download from KADhosts under Python 2.7 #372

Closed
StevenBlack opened this issue Aug 1, 2017 · 5 comments
Closed

updateHostsFile.py fails to download from KADhosts under Python 2.7 #372

StevenBlack opened this issue Aug 1, 2017 · 5 comments
Labels
bug pull request wanted

Comments

@StevenBlack
Copy link
Owner

Seeing this under Python 2.7.

 Error in updating source:  https://raw.githubusercontent.com/azet12/KADhosts/master/KADhosts.txt

I suspect that write_data is failing because of newly added cyrillic characters in commit 2bb7c27.
@ARROWBOW
Copy link

ARROWBOW commented Aug 1, 2017

Unable to use it.Not working.

@StevenBlack StevenBlack mentioned this issue Aug 12, 2017
Closed
@funilrys
Copy link
Contributor

Gonna try to fix it once I have time but if someone else have time to write a PR:

Here's in my opinion the best way to achieve the string decoding/encoding: https://stackoverflow.com/a/15918519/5308363

@FadeMind FadeMind mentioned this issue Aug 20, 2017
Closed
azet12 added a commit to FiltersHeroes/KADhosts that referenced this issue Aug 21, 2017
@azet12
Aktualizacja H2017082101
0649a5b 
Zawiera dane z wersji 2017081501 i 2017081801.
fix #6
fix #7, StevenBlack/hosts#372 - deleted Polish letters.
@FadeMind
Copy link
Contributor

@StevenBlack FIXED in FiltersHeroes/KADhosts@0649a5b

@StevenBlack
Copy link
Owner Author

Thanks Tomasz @FadeMind.

We still need to fix the encoding issue on Python 2.7...

@StevenBlack StevenBlack mentioned this issue Jan 5, 2018
Closed
funilrys added a commit to funilrys/hosts that referenced this issue Feb 28, 2018
@funilrys
Review of get_file_by_url()
c82f691 
Please note that this patch also introduce
which is in charge of converting a domain in a line into
IDNA and/or UTF-8 format.

Also note the introduction of BeautifulSoup() which helps
us to decode data from the downloaded URL.

Fixes (issue(s)/protocol(s) I was able to reproduce):
 * StevenBlack#514 (comment)

Possible fix of (issue(s)/protocol(s) I wasn't able to reproduce):
 * StevenBlack#514 (comment)
 * StevenBlack#494 (comment)
 * StevenBlack#420 (comment)
 * StevenBlack#372 (comment)
 * StevenBlack#382 (comment)
@funilrys funilrys mentioned this issue Feb 28, 2018
Merged
@funilrys
Copy link
Contributor

funilrys commented Mar 3, 2018

You can also close this @StevenBlack 👍

faultables pushed a commit to evilfactorylabs/gatekeeper that referenced this issue Jan 23, 2021
@funilrys
Review of get_file_by_url()
0bfacad 
Please note that this patch also introduce
which is in charge of converting a domain in a line into
IDNA and/or UTF-8 format.

Also note the introduction of BeautifulSoup() which helps
us to decode data from the downloaded URL.

Fixes (issue(s)/protocol(s) I was able to reproduce):
 * StevenBlack/hosts#514 (comment)

Possible fix of (issue(s)/protocol(s) I wasn't able to reproduce):
 * StevenBlack/hosts#514 (comment)
 * StevenBlack/hosts#494 (comment)
 * StevenBlack/hosts#420 (comment)
 * StevenBlack/hosts#372 (comment)
 * StevenBlack/hosts#382 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug pull request wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@StevenBlack @FadeMind @funilrys @ARROWBOW