Fix directory separator under Windows.

[funilrys]

This patch fixes #1332.

[funilrys]

Please check @XhmikosR @onmyouji.

Stay safe and healthy.
Nissar

[StevenBlack]

Ping @XhmikosR and @onmyouji. I'd like to merge this. Is this cool on Win?

[XhmikosR]

C:\Users\xmr\Desktop\hosts>python testUpdateHostsFile.py
..............................................................................................F.FF............
======================================================================
FAIL: test_add_fields (__main__.TestUpdateReadmeData)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "testUpdateHostsFile.py", line 1136, in test_add_fields
    self.assertEqual(actual, expected)
AssertionError: {'foo': 'bar', 'base': {'location': 'foo/',[34 chars]ts'}} != {'base': {'location': 'foo\\', 'sourcesdata[35 chars]bar'}
- {'base': {'entries': 5, 'location': 'foo/', 'sourcesdata': 'hosts'},
?                                         ^

+ {'base': {'entries': 5, 'location': 'foo\\', 'sourcesdata': 'hosts'},
?                                         ^^

   'foo': 'bar'}

======================================================================
FAIL: test_modify_fields (__main__.TestUpdateReadmeData)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "testUpdateHostsFile.py", line 1153, in test_modify_fields
    self.assertEqual(actual, expected)
AssertionError: {'base': {'location': 'foo/', 'entries': 5, 'sourcesdata': 'hosts'}} != {'base': {'location': 'foo\\', 'sourcesdata': 'hosts', 'entries': 5}}
- {'base': {'entries': 5, 'location': 'foo/', 'sourcesdata': 'hosts'}}
?                                         ^

+ {'base': {'entries': 5, 'location': 'foo\\', 'sourcesdata': 'hosts'}}
?                                         ^^


======================================================================
FAIL: test_set_extensions (__main__.TestUpdateReadmeData)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "testUpdateHostsFile.py", line 1177, in test_set_extensions
    self.assertEqual(actual, expected)
AssertionError: {'com-org': {'location': 'foo/', 'entries': 5, 'sourcesdata': 'hosts'}} != {'com-org': {'location': 'foo\\', 'sourcesdata': 'hosts', 'entries': 5}}
- {'com-org': {'entries': 5, 'location': 'foo/', 'sourcesdata': 'hosts'}}
?                                            ^

+ {'com-org': {'entries': 5, 'location': 'foo\\', 'sourcesdata': 'hosts'}}
?                                            ^^


----------------------------------------------------------------------
Ran 110 tests in 0.080s

FAILED (failures=3)

[onmyouji]

It still fails

python .\testUpdateHostsFile.py
..............................................................................................F.FF............
======================================================================
FAIL: test_add_fields (__main__.TestUpdateReadmeData)
----------------------------------------------------------------------
Traceback (most recent call last):
  File ".\testUpdateHostsFile.py", line 1139, in test_add_fields
    self.assertEqual(actual, expected)
AssertionError: {'foo': 'bar', 'base': {'location': 'foo/',[34 chars]ts'}} != {'base': {'location': 'foo\\', 'sourcesdata[35 chars]bar'}
- {'base': {'entries': 5, 'location': 'foo/', 'sourcesdata': 'hosts'},
?                                         ^

+ {'base': {'entries': 5, 'location': 'foo\\', 'sourcesdata': 'hosts'},
?                                         ^^

   'foo': 'bar'}

======================================================================
FAIL: test_modify_fields (__main__.TestUpdateReadmeData)
----------------------------------------------------------------------
Traceback (most recent call last):
  File ".\testUpdateHostsFile.py", line 1156, in test_modify_fields
    self.assertEqual(actual, expected)
AssertionError: {'base': {'location': 'foo/', 'entries': 5, 'sourcesdata': 'hosts'}} != {'base': {'location': 'foo\\', 'sourcesdata': 'hosts', 'entries': 5}}
- {'base': {'entries': 5, 'location': 'foo/', 'sourcesdata': 'hosts'}}
?                                         ^

+ {'base': {'entries': 5, 'location': 'foo\\', 'sourcesdata': 'hosts'}}
?                                         ^^


======================================================================
FAIL: test_set_extensions (__main__.TestUpdateReadmeData)
----------------------------------------------------------------------
Traceback (most recent call last):
  File ".\testUpdateHostsFile.py", line 1180, in test_set_extensions
    self.assertEqual(actual, expected)
AssertionError: {'com-org': {'location': 'foo/', 'entries': 5, 'sourcesdata': 'hosts'}} != {'com-org': {'location': 'foo\\', 'sourcesdata': 'hosts', 'entries': 5}}
- {'com-org': {'entries': 5, 'location': 'foo/', 'sourcesdata': 'hosts'}}
?                                            ^

+ {'com-org': {'entries': 5, 'location': 'foo\\', 'sourcesdata': 'hosts'}}
?                                            ^^


----------------------------------------------------------------------
Ran 110 tests in 0.110s

FAILED (failures=3)

[funilrys]

Please recheck with my latest change @onmyouji @XhmikosR !

Stay safe and healthy.
Nissar

[onmyouji]

python .\testUpdateHostsFile.py
............................F...............F.F...............................................................
======================================================================
FAIL: test_get_defaults (__main__.TestGetDefaults)
----------------------------------------------------------------------
Traceback (most recent call last):
  File ".\testUpdateHostsFile.py", line 132, in test_get_defaults
    self.assertDictEqual(actual, expected)
AssertionError: {'num[27 chars] 'foo\\data', 'freshen': True, 'replace': Fals[619 chars]ist'} != {'num[27 chars] 'foo/data', 'freshen': True, 'replace': False[613 chars]ist'}
Diff is 1349 characters long. Set self.maxDiff to None to see it.

======================================================================
FAIL: test_join (__main__.TestPathJoinRobust)
----------------------------------------------------------------------
Traceback (most recent call last):
  File ".\testUpdateHostsFile.py", line 1882, in test_join
    self.assertEqual(actual, expected)
AssertionError: 'path1\\pathNew' != 'path1/pathNew'
- path1\pathNew
?      ^
+ path1/pathNew
?      ^


======================================================================
FAIL: test_join_unicode (__main__.TestPathJoinRobust)
----------------------------------------------------------------------
Traceback (most recent call last):
  File ".\testUpdateHostsFile.py", line 1890, in test_join_unicode
    self.assertEqual(actual, expected)
AssertionError: 'path1\\pathNew' != 'path1/pathNew'
- path1\pathNew
?      ^
+ path1/pathNew
?      ^


----------------------------------------------------------------------
Ran 110 tests in 0.120s

FAILED (failures=3)

[funilrys]

Thanks for the feedback @onmyouji. Can you test again (hopefully for the last time for this issue) ?

Thanks again for your feedback!

[onmyouji]

python .\testUpdateHostsFile.py
..............................................................................................................
----------------------------------------------------------------------
Ran 110 tests in 0.097s

OK

[funilrys]

It's yours Steve @StevenBlack !

[StevenBlack]

THANK YOU everyone! Excellent effort Nissar @funilrys.

Merging!