Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed minor issues in shared-library & workflow #18

Merged
merged 2 commits into from
May 6, 2024

Conversation

StevenJDH
Copy link
Owner

Description

This pull request fixes a few minor issues in the library and a 422 scenario in the release workflow when commits are detected in other chart but aren't tied to a release.

Dependencies:

  • N/A

Does this introduce a breaking change?

  • Yes
  • No

Pull Request Type

What kind of change does this Pull Request introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables, renaming)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes
  • Other (please describe):

How has this been tested?

  • Chart testing (ct lint).
  • KIND tests.
  • Full deployment.

Test Configuration:

  • chart-testing v3.10.1
  • KIND 1.19.x and 1.24.x, 1.29.x.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Other Information

N/A

@StevenJDH StevenJDH added bug Something isn't working documentation Improvements or additions to documentation labels May 6, 2024
@StevenJDH StevenJDH self-assigned this May 6, 2024
@cla-bot cla-bot bot added the cla-signed label May 6, 2024
@StevenJDH StevenJDH changed the title Fixed various minor issues in the shared-library Fixed minor issues in shared-library & workflow May 6, 2024
@StevenJDH StevenJDH merged commit 7838232 into main May 6, 2024
4 checks passed
@StevenJDH StevenJDH deleted the chart/shared-library branch May 6, 2024 21:56
Repository owner locked as resolved and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant