Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated konga chart to use shared-library #19

Merged
merged 1 commit into from
May 7, 2024
Merged

Updated konga chart to use shared-library #19

merged 1 commit into from
May 7, 2024

Conversation

StevenJDH
Copy link
Owner

Description

This pull request updates the helm chart for konga to make use of the shared-library and to apply a few minor fixes.

Dependencies:

  • shared-library chart 0.1.3
  • kong chart ^9.x

Does this introduce a breaking change?

  • Yes
  • No

Pull Request Type

What kind of change does this Pull Request introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables, renaming)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes
  • Other (please describe):

How has this been tested?

  • Chart testing (ct lint).
  • KIND tests.
  • Full deployment.

Test Configuration:

  • chart-testing v3.10.1
  • KIND 1.19.x and 1.24.x, 1.29.x.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Other Information

N/A

@StevenJDH StevenJDH added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels May 7, 2024
@StevenJDH StevenJDH self-assigned this May 7, 2024
@cla-bot cla-bot bot added the cla-signed label May 7, 2024
@StevenJDH StevenJDH merged commit 8b42b77 into main May 7, 2024
10 checks passed
@StevenJDH StevenJDH deleted the chart/konga branch May 7, 2024 22:49
Repository owner locked as resolved and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working cla-signed documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant