-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added check that album art uri is a valid string #215
Conversation
Some Samsung TVs return a profile that has an "album_art_uri" property set to None. As-was, this caused a string handling error in the absolute_url call. Fix is to simply check that the uri is not null before the call.
Hi @darrynlowe, thank you for the PR! Can you add a test for this? |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## development #215 +/- ##
============================================
Coverage 72.42% 72.42%
============================================
Files 19 19
Lines 4043 4043
============================================
Hits 2928 2928
Misses 1115 1115 ☔ View full report in Codecov by Sentry. |
Thanks! Do you want a release with this? |
Thanks for merging in. No need for a special release for my sake given you release so frequently already (which is great, btw). |
There is a low chance of a change resulting from a home assistant issue. I'll await the results from that issue and create a new release after that. |
No activity regarding the home assistant issue. This weekend I'll create 0.38.1 to include this PR. |
I've released 0.38.1. I'm unsure if you were experiencing the issue via home assistant, but I'll create a PR there to bump this library. |
The release is already in home assistant, see https://www.home-assistant.io/blog/2024/01/03/release-20241/#release-202415---january-20 Hope this fixes the problem with your TV. |
Works great - thanks for help! |
Some Samsung TVs return a profile that has an "album_art_uri" property set to None. As-was, this caused a string handling error in the absolute_url call. Fix is to simply check that the uri is not null before the call.