Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check that album art uri is a valid string #215

Merged
merged 4 commits into from
Jan 5, 2024

Conversation

darrynlowe
Copy link
Contributor

Some Samsung TVs return a profile that has an "album_art_uri" property set to None. As-was, this caused a string handling error in the absolute_url call. Fix is to simply check that the uri is not null before the call.

Some Samsung TVs return a profile that has an "album_art_uri" property set to None. As-was, this caused a string handling error in the absolute_url call. Fix is to simply check that the uri is not null before the call.
@StevenLooman
Copy link
Owner

StevenLooman commented Jan 1, 2024

Hi @darrynlowe, thank you for the PR! Can you add a test for this?

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e76d867) 72.42% compared to head (571b139) 72.42%.

Files Patch % Lines
async_upnp_client/profiles/dlna.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           development     #215   +/-   ##
============================================
  Coverage        72.42%   72.42%           
============================================
  Files               19       19           
  Lines             4043     4043           
============================================
  Hits              2928     2928           
  Misses            1115     1115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StevenLooman StevenLooman merged commit e3228b1 into StevenLooman:development Jan 5, 2024
8 of 9 checks passed
@StevenLooman
Copy link
Owner

Thanks! Do you want a release with this?

@darrynlowe
Copy link
Contributor Author

Thanks for merging in. No need for a special release for my sake given you release so frequently already (which is great, btw).

@StevenLooman
Copy link
Owner

There is a low chance of a change resulting from a home assistant issue. I'll await the results from that issue and create a new release after that.

@StevenLooman
Copy link
Owner

No activity regarding the home assistant issue. This weekend I'll create 0.38.1 to include this PR.

@StevenLooman
Copy link
Owner

I've released 0.38.1. I'm unsure if you were experiencing the issue via home assistant, but I'll create a PR there to bump this library.

@StevenLooman
Copy link
Owner

The release is already in home assistant, see https://www.home-assistant.io/blog/2024/01/03/release-20241/#release-202415---january-20

Hope this fixes the problem with your TV.

@darrynlowe darrynlowe deleted the patch-1 branch January 21, 2024 21:43
@darrynlowe
Copy link
Contributor Author

Works great - thanks for help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants