Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish-checks-wiki: setup Python and remove commented code #61

Closed
wants to merge 5 commits into from

Conversation

sebastiaanspeck
Copy link
Contributor

@sebastiaanspeck sebastiaanspeck commented Feb 26, 2024

A little note I too want to mention. Even if nothing changed, this workflow will create a new empty commit to the Wiki

@StevenLooman
Copy link
Owner

Thank you for this PR @sebastiaanspeck. On (at least) Debian based distros, such as Ubuntu, it is "standard" to use python3 instead of python. I cannot find the source where I read/heard this. Perhaps PEP394 does shed some light on this. You are right of course, that nobody will be using (or at least should be using) Python2 these days!

Also, the #dry-run: true was left there to show my future self (and others) that it is possible to do a dry run.

A little note I too want to mention. Even if nothing changed, this workflow will create a new empty commit to the Wiki

Yes, this is true and certainly a downside. Yet, I find the downside acceptable compared to writing an action myself as this would certainly cost more time.

In the end, thank you for this PR, but I don't see the need to merge this. I am glad you trying to find improvements though!

@sebastiaanspeck
Copy link
Contributor Author

Thank you for this PR @sebastiaanspeck. On (at least) Debian based distros, such as Ubuntu, it is "standard" to use python3 instead of python. I cannot find the source where I read/heard this. Perhaps PEP394 does shed some light on this. You are right of course, that nobody will be using (or at least should be using) Python2 these days!

The reason I changed it, was that you can combine the two python3 commands into one. Was not fully aware I changed it from python3 to python.

@StevenLooman
Copy link
Owner

I noticed this too but I don't see any advantage or disadvantage to it. There isn't going to be any additional "layer" like in Docker. The overhead is minimal and it's not going to be ran that often anyway.

@StevenLooman
Copy link
Owner

To add, I expect this to change in the future, when perhaps a v5 of the Andrew-Chen-Wang/github-wiki-action is released (if ever.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants