[Release v1.0.0] Merge dev into main #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove RForcecom from roxygen documentation and from the Suggests packages. Later we may need to remove from vignettes. Closes #101
Remove RForcecom from roxygen documentation and from the Suggests packages. Later we may need to remove from vignettes. Closes #97
Salesforce returns dates and datetimes in UTC but sometimes as YYYY-MM-DD or MM/DD/YYYY in the case of reports, so we will convert using the anytime package rather than trusting type_convert()'s behavior. Allow users to pass guess_types directly to sf_run_report() in case they still want to do that and parse the character strings on their own Closes #93
Fix the casting of all common columns between the different record sets by ensuring that only one class is selected after identifying it with the class() function. Allow users to specify the `combine_record_types` argument directly in higher level functions like `sf_upsert()` and have it passed through if the API is set to "Bulk 2.0" Closes #95
Set the version number to 1.0.0 to match notion behind the lifecycle status "Stable", which is now used in place of "Maturing"
The check on Windows stated that an error happened while processing because the there was no package RForcecom, which should not be the case Error: Error: processing vignette 'transitioning-from-RForcecom.Rmd' failed with diagnostics: there is no package called 'RForcecom' https://github.com/StevenMMortimer/salesforcer/runs/2985296515?check_suite_focus=true
Fix error that appears to be related to using knitr as the vignette builder engine. Switching to rmarkdown appears to be the solution: https://community.rstudio.com/t/devtools-check-error-with-vignette-but-vignette-can-be-knitted-without-problem/55962
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
salesforcer 1.0.0
Dependencies
Remove uses of {RForcecom} after it was removed from CRAN on 6/9/2021 (salesforcer removed from CRAN #101)
Remove LazyData option in DESCRIPTION since
data()is not utilizedDeprecate argument in
sf_write_csv()frompathtofileas was done in{readr} v1.4.0.
Deprecate argument
bind_using_character_colsbecause we will always needto bind as character and then parse if
guess_types=TRUE. Per comments inguess_max = Inf tidyverse/readr#588 and Better support for reading compressed files tidyverse/readr#98, we must read all of the data as
character first and then use
type_convert()to ensure that we use all valuesin the column to guess the type. The default for
read_csv()is to only usethe first 1,000 rows and its
guess_maxargument cannot be set toInf.Change lifecycle status from "Maturing" to "Status" per the retirement of
"Maturing" in the {lifecycle} package. The documentation notes:
In addition, the lifecycle guidance states that experimental packages have
version numbers less than 1.0.0 and may have major changes in its future.
The {salesforcer} package has achieved a stable state with core
functionality implemented and a focus on backwards compatibility due to the
volume of users.
Features
Improve documentation to retrieve the access token or session ID after
authentication (Make it easier to get access token #97)
Improve parsing of Bulk API query recordsets from CSV where all values
in the column will be used to guess the type instead of the first 1000.
Bug fixes
Generalize the date and datetime parsing mechanism, such that, reports with
date and datetime fields are not returned as NA (Date column in mm/dd/yyyy format in salesforce report produces NA in results tibble #93)
Fix the format of the
OwnerChangeOptionsheader so it is accepted (Error returned with OwnerChangeOptions of sf_control() #94)Fix bug that caused Bulk 2.0 calls to crash when the results had datetime
fields in the recordset (Datetime columns break internal sf_get_job_records_bulk_v2 #95)