Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Retro] Event conflicts in grouping phase can wipe group names #518

Closed
StevenWeathers opened this issue Mar 27, 2024 · 4 comments
Closed
Assignees
Labels
bug Something isn't working Retro

Comments

@StevenWeathers
Copy link
Owner

StevenWeathers commented Mar 27, 2024

It's been reported that sometimes when multiple users are manipulating groups the group names can get wiped out.

One possible solution is to separate grouping and naming groups into unique phases.

@StevenWeathers StevenWeathers added the bug Something isn't working label Mar 27, 2024
@scottux
Copy link
Collaborator

scottux commented Mar 27, 2024

Seems like an opportunity to make the e2e tests more active if that makes sense. I am not sure how else to test these situations.

While testing the grouping, have some simulated backend chatter, and have the group moved around and keep checking the state of it?

@StevenWeathers
Copy link
Owner Author

My experience with e2e tests would say that'll be difficult to simulate, mainly because I'm not certain if it's a network timing issue. I do see a possible simple fix in how the grouping and naming events are handled on the UI. Currently they update all the groups, even though only one was changed. It would be best to make them more targeted which should fix the issue I think.

@StevenWeathers
Copy link
Owner Author

PR #531 hopefully resolves this issue by reducing the impacts of socket events on grouping phase and also no longer sorts the groups during grouping phase which would cause a jarring experience.

@StevenWeathers
Copy link
Owner Author

Marking this done, if it occurs again will reopen or open new ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Retro
Projects
None yet
Development

No branches or pull requests

2 participants