Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix header auth, could not configure AuthHeaderEmailHeader #554

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

Kaffeetasse
Copy link
Contributor

Description

This PR fixes the bug regarding the Header Authentication AuthHeaderEmailHeader, as it was not possible to configure a Header name.

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Screenshots/Recordings

Steps to QA

  • Configure Header Authentication for example:
AUTH_METHOD: "header"
AUTH_HEADER_USERNAME_HEADER: "x-token-user-name"
AUTH_HEADER_EMAIL_HEADER: "x-token-user-email"
  • Now a User can login but the E-Mail field will be empty.

@StevenWeathers
Copy link
Owner

Please run goimports -w . to fix the go formatting so the build lint step will pass.

@Kaffeetasse
Copy link
Contributor Author

@StevenWeathers sorry I did not think that this will be an issue, should now be fixed.

@StevenWeathers StevenWeathers merged commit 8f6fb2e into StevenWeathers:main Apr 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants