Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rollup with vite #564

Closed
wants to merge 17 commits into from
Closed

Replace rollup with vite #564

wants to merge 17 commits into from

Conversation

StevenWeathers
Copy link
Owner

@StevenWeathers StevenWeathers commented Apr 6, 2024

Description

Replaces rollup with Vite

Pros

  • Faster UI builds
  • Bundling with Dynamic Imports which aids in page load performance and reduces unnecessary (example Admin for all non admins) UI code being loaded

Cons

  • Some behaviors of compiled code are different and required some minor changes
  • Svelte style blocks using tailwind classes are not working properly, might be bundling or the postcss/tailwind configuraiton
  • Currently unsure how to support PathPrefix feature due to dynamic imports pathing (hard requirement to maintain Thunderdome v3, or deprecate and release as v4)

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Screenshots/Recordings

Steps to QA

@StevenWeathers StevenWeathers added the enhancement New feature or request label Apr 6, 2024
scottux
scottux previously approved these changes Apr 7, 2024
@StevenWeathers
Copy link
Owner Author

Closing due to inability to get Vite to feature parity with Rollup, tried numerous ways to support the PathPrefix feature however nothing seems to work in the way necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants