Support frozenset #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Stewori#35.
mitar
commented
Apr 13, 2018
| @@ -22,10 +22,10 @@ | |||
| import collections | |||
| from inspect import isfunction, ismethod, isclass, ismodule | |||
| try: | |||
| from backports.typing import Tuple, Dict, List, Set, Union, Any, \ | |||
| from backports.typing import Tuple, Dict, List, Set, FrozenSet, Union, Any, \ | |||
There was a problem hiding this comment.
Not sure if this exists.
Stewori
reviewed
Apr 13, 2018
| @@ -4664,6 +4664,10 @@ class Foo(typing.Generic[T]): | |||
| # No exception. | |||
| resolve_fw_decl(Foo) | |||
|
|
|||
| # See: https://github.com/Stewori/pytypes/issues/35 | |||
| def test_frozenset(self): | |||
| self.assertTrue(pytypes.is_of_type(frozenset({1, 2, 'a', None, 'b'}), typing.AbstractSet[typing.Union[str, int, None]])) | |||
There was a problem hiding this comment.
I aim to keep line widths < 80 according to pep 8. I know that many parts of pytypes are far away from pep 8 compliance, but in general I try to converge it to pep 8 rather than further away from it....
This is just cosmetic, so I would not consider it a blocker for accepting this PR.
There was a problem hiding this comment.
I often ignore PEP8 a little in tests in my code.
|
Thanks for this fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35.