Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime modes, status announcements, discord control #7

Merged
merged 41 commits into from Jan 16, 2021
Merged

Runtime modes, status announcements, discord control #7

merged 41 commits into from Jan 16, 2021

Conversation

stryan
Copy link
Contributor

@stryan stryan commented Jan 14, 2021

As mentioned in #6, here's the big PR with roughly the following feature list:

  • Three separate runtime modes: constant (as it is now), manual, and automatic startup
  • Discord bot shows number of users in mumble as status
  • Control the bridge through Discord
  • Announcements in Mumble when user joins Discord
  • Auto-join specific Mumble channel

@Stieneee
Copy link
Owner

Everything looks good.

Last night I tried it out and it behaved as expected. I noticed CPU load was high and found a sneaky default case in the mumble onAudioStream event handler. I will apply my patch after I merge.

I believe the default mode should be constant or automatic as I believe many people will struggle to figure out why the bridge is not working without clear instruction. I believe having it work out of the box is better than having to provide instruction.

@Stieneee Stieneee merged commit f92b973 into Stieneee:main Jan 16, 2021
@stryan
Copy link
Contributor Author

stryan commented Jan 16, 2021

Ah, good catch, I saw pull-7.

But sure, that makes sense. I've already got another PR incoming that uses some of your feedback from the initial issue and fixes some of the announcement code. It's much smaller then this one so I'll just sneak the default modeset in there. To keep continuity with how the original code worked I'll set constant as the default.

EDIT: ignore that, I see your commits already.

Stieneee pushed a commit that referenced this pull request Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants