Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup efsearch more #76

Merged
merged 10 commits into from Dec 20, 2019
Merged

Speedup efsearch more #76

merged 10 commits into from Dec 20, 2019

Conversation

matteobachetti
Copy link
Member

@matteobachetti matteobachetti commented Dec 20, 2019

This uses a bunch of optimizations to speed up by a large factor the Z squared statistics calculation and by a smaller amount the rest of the processing.

@pep8speaks
Copy link

pep8speaks commented Dec 20, 2019

Hello @matteobachetti! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 212:1: E302 expected 2 blank lines, found 1
Line 218:80: E501 line too long (92 > 79 characters)
Line 229:17: E127 continuation line over-indented for visual indent
Line 229:80: E501 line too long (86 > 79 characters)
Line 632:80: E501 line too long (81 > 79 characters)

Comment last updated at 2019-12-20 09:19:46 UTC

@coveralls
Copy link

coveralls commented Dec 20, 2019

Coverage Status

Coverage increased (+0.4%) to 93.487% when pulling aef4ce0 on speedup_efsearch_further into 11a24cd on master.

@matteobachetti matteobachetti changed the title Speedup by some factor. Speedup efsearch more Dec 20, 2019
@matteobachetti matteobachetti merged commit 7944399 into master Dec 20, 2019
@matteobachetti matteobachetti deleted the speedup_efsearch_further branch November 26, 2020 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants