Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the unnecessary *= -1 from Spectral Timing Exploration.ipynb #64

Merged
merged 3 commits into from
Mar 10, 2023

Conversation

pupperemeritus
Copy link
Contributor

@pupperemeritus pupperemeritus commented Mar 4, 2023

Tried to fix the issue StingraySoftware/stingray#691. Please provide feedback. One change that happened in the time lag - frequency graph has flipped from the result in the documentation. I am not sure whether it is occuring due to an intended change or I messed up something. The large deletion count is due to the progress bars rendering dynamically in one line as opposed to one line for each percentage.

@matteobachetti
Copy link
Member

Thanks @pupperemeritus
Now that you're at it, the string f"Time lag ({ref_band[0]:g}-{ref_band[1]:g} keV vs {sub_band[0]:g}-{sub_band[1]:g} keV, in seconds)" should be changed, inverting ref_band and sub_band

@pupperemeritus
Copy link
Contributor Author

Changed it

@matteobachetti
Copy link
Member

Thanks @pupperemeritus!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants