Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GTI keyword mismatch in pulse.pulsar.fold_events #480

Closed
gabrielb09 opened this issue Jul 14, 2020 · 1 comment
Closed

GTI keyword mismatch in pulse.pulsar.fold_events #480

gabrielb09 opened this issue Jul 14, 2020 · 1 comment
Labels
docs Issues regarding the documentation. low-priority Low-priority issues.
Milestone
version 1.0.0 docs

Comments

@gabrielb09
Copy link

Nearly everything in stingray uses gti as the keyword for GTI's however, for fold_events, the keyword is gtis. This is an issue since epoch_folding_search uses the standard gti keyword and eventually passes its keyword arguments to fold_events.
@matteobachetti
Copy link
Member

matteobachetti commented Jul 14, 2020 •
edited
Loading

Hi @gabrielb09, thanks a lot for your detailed report. We'll get to this asap.

@matteobachetti matteobachetti added the low-priority Low-priority issues. label Jan 18, 2021
@abigailStev abigailStev mentioned this issue Feb 18, 2022
Merged
@abigailStev abigailStev added this to the version 1.0.0 docs milestone Mar 26, 2022
@abigailStev abigailStev added the docs Issues regarding the documentation. label Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Issues regarding the documentation. low-priority Low-priority issues.
Projects
None yet
Milestone
version 1.0.0 docs
Development

No branches or pull requests
3 participants
@abigailStev @matteobachetti @gabrielb09