Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve loading of event lists for XMM, NuSTAR, Swift, NICER #502

Merged
merged 10 commits into from
Dec 10, 2020

Conversation

matteobachetti
Copy link
Member

@matteobachetti matteobachetti commented Oct 11, 2020

A number of improvements in how events are loaded, GTI extensions are understoood, and so on.

This was triggered by the Slack request from @bwgref:

Hey all. During Daniela's talk to Shri's X-ray club I think I saw some examples of reading in 
event files with GTIs, etc. But looking through the tutorial notebooks I can't seem to find an 
example of how this is supposed to actually work (so now I'm heading to readthedocs instead). 
Is there a "dealing with real satellite data" notebook example yet? And/or I'm willing to help 
make one if there isn't.

These changes will make the writing of such notebook much easier I hope :)

Copy link
Member

@dhuppenkothen dhuppenkothen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This'll be really useful. However, it needs more documentation and tests. :)

stingray/gti.py Outdated Show resolved Hide resolved
stingray/gti.py Show resolved Hide resolved
stingray/gti.py Outdated Show resolved Hide resolved
stingray/gti.py Outdated Show resolved Hide resolved
stingray/gti.py Show resolved Hide resolved
stingray/io.py Show resolved Hide resolved
stingray/io.py Outdated Show resolved Hide resolved
stingray/io.py Outdated Show resolved Hide resolved
stingray/io.py Show resolved Hide resolved
stingray/io.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #502 (e0b2d81) into master (88e2213) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #502      +/-   ##
==========================================
+ Coverage   95.29%   95.42%   +0.13%     
==========================================
  Files          35       35              
  Lines        5354     5426      +72     
==========================================
+ Hits         5102     5178      +76     
+ Misses        252      248       -4     
Impacted Files Coverage Δ
stingray/gti.py 98.30% <100.00%> (+0.40%) ⬆️
stingray/io.py 94.03% <100.00%> (+1.34%) ⬆️
stingray/events.py 100.00% <0.00%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88e2213...fe9c645. Read the comment docs.

Copy link
Member

@dhuppenkothen dhuppenkothen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Probably means that the documentation needs an update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants