-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve loading of event lists for XMM, NuSTAR, Swift, NICER #502
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This'll be really useful. However, it needs more documentation and tests. :)
dbf9fae
to
d1416f5
Compare
Codecov Report
@@ Coverage Diff @@
## master #502 +/- ##
==========================================
+ Coverage 95.29% 95.42% +0.13%
==========================================
Files 35 35
Lines 5354 5426 +72
==========================================
+ Hits 5102 5178 +76
+ Misses 252 248 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Probably means that the documentation needs an update?
A number of improvements in how events are loaded, GTI extensions are understoood, and so on.
This was triggered by the Slack request from @bwgref:
These changes will make the writing of such notebook much easier I hope :)