Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if invalid data are inside gtis, and warn or raise exception accordingly #730

Merged
merged 8 commits into from
May 23, 2023
Merged

Check if invalid data are inside gtis, and warn or raise exception accordingly #730

merged 8 commits into from
May 23, 2023

Conversation

matteobachetti
Copy link
Member

Resolve #728

@codecov
Copy link

codecov bot commented May 18, 2023 •
edited
Loading

Codecov Report

Merging #730 (0796687) into main (900d81a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #730   +/-   ##
=======================================
  Coverage   97.16%   97.17%           
=======================================
  Files          42       42           
  Lines        7843     7865   +22     
=======================================
+ Hits         7621     7643   +22     
  Misses        222      222
Impacted Files Coverage Δ
stingray/lightcurve.py 97.85% <100.00%> (+0.02%) ⬆️
stingray/utils.py 98.50% <100.00%> (+0.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@matteobachetti matteobachetti changed the title [WIP] Check if invalid data are inside gtis, and warn or raise exception accordingly Check if invalid data are inside gtis, and warn or raise exception accordingly May 18, 2023
dhuppenkothen
dhuppenkothen approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@dhuppenkothen dhuppenkothen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One change that I don't quite understand, but I'm sure you have your reasons. :)

stingray/lightcurve.py Show resolved Hide resolved
@matteobachetti matteobachetti added this pull request to the merge queue May 23, 2023
Merged via the queue into main with commit f1d033a May 23, 2023
13 checks passed
@matteobachetti matteobachetti deleted the warn_for_nans branch May 23, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhuppenkothen dhuppenkothen dhuppenkothen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reading light curve with NaN
2 participants
@matteobachetti @dhuppenkothen