Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify numba mocking functions and improve docs #731

Merged
merged 6 commits into from
May 23, 2023

Conversation

matteobachetti
Copy link
Member

@matteobachetti matteobachetti commented May 20, 2023

This simplifies the creation of mock numba decorators, going to the barebones of the decorator behavior and avoiding duplication. It still works as expected, and I suspect (I'm not 100% sure) that it will help estimating coverage in numba-compiled functions during our test runs.

I also added a section on dependencies in the docs. I see that people do not often realize how useful it is to install numba!

@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Merging #731 (55ee6e0) into main (1c85c6b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #731   +/-   ##
=======================================
  Coverage   97.15%   97.16%           
=======================================
  Files          42       42           
  Lines        7852     7843    -9     
=======================================
- Hits         7629     7621    -8     
+ Misses        223      222    -1     
Impacted Files Coverage Δ
stingray/utils.py 98.46% <100.00%> (+0.16%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@matteobachetti matteobachetti changed the title Simplify numba mocking functions Simplify numba mocking functions and improve docs May 22, 2023
Copy link
Member

@dhuppenkothen dhuppenkothen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. I like the extra information in the docs. two questions about package dependencies, but otherwise I think this can get merged. :)

docs/install.rst Outdated Show resolved Hide resolved
docs/install.rst Show resolved Hide resolved
@matteobachetti matteobachetti added this pull request to the merge queue May 23, 2023
Merged via the queue into main with commit 900d81a May 23, 2023
13 checks passed
@matteobachetti matteobachetti deleted the simplify_numba_mock branch May 23, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants