Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compute rms #792

Merged
merged 23 commits into from
Jan 29, 2024
Merged

Fix compute rms #792

merged 23 commits into from
Jan 29, 2024

Commits on Jan 26, 2024

  1. New function to calculate rms, with checked error bars

    @matteobachetti
    matteobachetti committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    231ce7a View commit details
    Browse the repository at this point in the history

  2. Fix non-passing tests

    @matteobachetti
    matteobachetti committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    73a23aa View commit details
    Browse the repository at this point in the history

  3. Add changelog

    @matteobachetti
    matteobachetti committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    75625cb View commit details
    Browse the repository at this point in the history

  4. Fix typo

    @matteobachetti
    matteobachetti committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    06a9fb2 View commit details
    Browse the repository at this point in the history

  5. Implement substitute function for unnormalized powers and deprecate o… 

    …ld one
    @matteobachetti
    matteobachetti committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    ce3bdd5 View commit details
    Browse the repository at this point in the history

  6. Warn for M<30; test properly

    @matteobachetti
    matteobachetti committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    2c58495 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2024

  1. Test deprecation

    @matteobachetti
    matteobachetti committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    aa94ecb View commit details
    Browse the repository at this point in the history

  2. Use new machinery and test properly. Eliminate deprecated behavior

    @matteobachetti
    matteobachetti committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    38dcd4e View commit details
    Browse the repository at this point in the history

  3. Cleanup useless code

    @matteobachetti
    matteobachetti committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    5cfe3f6 View commit details
    Browse the repository at this point in the history

  4. Eliminate error-prone and redundant test

    @matteobachetti
    matteobachetti committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    9dfb361 View commit details
    Browse the repository at this point in the history

  5. Fix multitaper class and test

    @matteobachetti
    matteobachetti committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    243f470 View commit details
    Browse the repository at this point in the history

  6. Code cleanup: top-level imports, remove unused imports, fix logical t… 

    …ests
    @matteobachetti
    matteobachetti committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    efad91e View commit details
    Browse the repository at this point in the history

  7. Fix case with abs norm

    @matteobachetti
    matteobachetti committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    2bdbdbf View commit details
    Browse the repository at this point in the history

  8. Cleanup code to avoid duplication

    @matteobachetti
    matteobachetti committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    69886f5 View commit details
    Browse the repository at this point in the history

  9. Test invalid kind

    @matteobachetti
    matteobachetti committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    d61e6d9 View commit details
    Browse the repository at this point in the history

  10. Update notebook

    @matteobachetti
    matteobachetti committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    27989a3 View commit details
    Browse the repository at this point in the history

  11. Fix missing show_progress import

    @matteobachetti
    matteobachetti committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    1fac308 View commit details
    Browse the repository at this point in the history

  12. Fix uncovered tests

    @matteobachetti
    matteobachetti committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    508f9ba View commit details
    Browse the repository at this point in the history

  13. Fix tests for pytest >8

    @matteobachetti
    matteobachetti committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    2880827 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2024

  1. Catch dt warning

    @matteobachetti
    matteobachetti committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    6c30946 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Expand warning to explain that one needs 30 segments

    @matteobachetti
    matteobachetti committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    02fe583 View commit details
    Browse the repository at this point in the history

  2. Small typo fix

    @matteobachetti
    matteobachetti committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    689a333 View commit details
    Browse the repository at this point in the history

  3. Add test with different spectral shape (and a QPO)

    @matteobachetti
    matteobachetti committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    10764e4 View commit details
    Browse the repository at this point in the history