Support calibration of XTE data in event mode

[matteobachetti]

I had to change a little the structure, so that mission support is a separate beast than simple I/O.

• XTE/PCA is now supported with the recommended calibration. Science Event files from the XTE archive (those starting with SE and GX) can now be loaded in Stingray. More versions of files can be added later

• Calibration functions are moved to a separate mission_support module

• Basic implementation

• Working tests

• Documentation on how to use this machinery

[pep8speaks]

Hello @matteobachetti! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file stingray/mission_support/rxte.py:

Line 283:31: E203 whitespace before ':'
Line 284:34: E203 whitespace before ':'

Comment last updated at 2024-05-07 09:47:27 UTC

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.54%. Comparing base (ca74d3c) to head (800056b).

❗ Current head 800056b differs from pull request most recent head 2896fa8. Consider uploading reports for the commit 2896fa8 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #816      +/-   ##
==========================================
+ Coverage   96.50%   96.54%   +0.03%     
==========================================
  Files          45       48       +3     
  Lines        9149     9254     +105     
==========================================
+ Hits         8829     8934     +105     
  Misses        320      320              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mgullik]

Hi @matteobachetti,

this is super! Having the possibility to work on the RXTE data is a big improvement for Stingray.

Sorry if I write something that is already implemented in other places of the code.

my questions/suggestions:

• in one of the doc string you wrote that the conversion from PHA to absolute PHA is done by the function pca_calibration_func using TEVTB2 keyword. However, I don't see how you use the TEVTB2 keyword in that function. Also the doc string of pca_calibration_func says that it's "A function that converts PHA channel to energy for PCU 0"
• does it make sense to create a test that checks if the conversion from channel to energy is correct? I've see a test on the data.pi_list, but I think this is for channels.
• Adding a test using a mission that is either not supported by Stingray or doesn't exist and catching the error message.

Cheers

[mgullik]

The format of the table changes here, it can get confusion to read and comparte

[matteobachetti]

This is the original table from the RXTE website, I maintained their format. I preferred to make the original table available instead of storing in a different format. Probably an excess of caution, but I figured it would have been easier to track possible changes over time

[mgullik]

I remember that format from years ago...I understand your point, even though looking at the table formatted in that way make me think that many mistakes had been and will be made :)

[matteobachetti]

I feel the pain