Avoid copy in memory of memmaps #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #824 +/- ##
==========================================
+ Coverage 96.47% 96.49% +0.02%
==========================================
Files 45 45
Lines 9135 9138 +3
==========================================
+ Hits 8813 8818 +5
+ Misses 322 320 -2 ☔ View full report in Codecov by Sentry. |
mgullik
approved these changes
May 7, 2024
There was a problem hiding this comment.
Hi @matteobachetti,
I don't see any problem with this. For me it's a go!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR substitutes all calls to
np.asarraywithnp.asanyarray, which passes all subclasses ofnp.ndarray(as, for example,np.memmap)Relevant Issue(s)/PR(s)
Resolve #823