Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Ability to personnalize URI #136

Closed
MayannF opened this issue May 9, 2023 · 3 comments
Closed

[Feature request] Ability to personnalize URI #136

MayannF opened this issue May 9, 2023 · 3 comments
Labels

Comments

@MayannF
Copy link
Contributor

MayannF commented May 9, 2023

Hi,

I would like to suggest a simple feature making possible to expose s-pdf behind a reverse proxy using subfolders.

I managed to make this work on a test container by simply adding
server.servlet.context-path=${CONTEXT_PATH:/} to application.properties.
With this, if I run the container with option -e CONTEXT_PATH=/s-pdf, the webapp is fully accessible from mydomain.com/s-pdf

If no option is passed, it keeps the default root path /.

I'm very new to git so I hope this is an appropriate contribution !

@Frooodle
Copy link
Member

Frooodle commented May 9, 2023

Awesome idea, thanks ill add this for next release, or if you want you can raise a PR

@MayannF
Copy link
Contributor Author

MayannF commented May 9, 2023

So glad you like the idea!

As said, I'm very new to git, but I'll try to make the PR tomorrow.

Btw huge thanks for the project, it's really amazing

MayannF added a commit to MayannF/Stirling-PDF that referenced this issue May 10, 2023
… the webapp behind a reverse proxy using subfolder. Minor changes to html pages to remove absolute path for some resources
Frooodle added a commit that referenced this issue May 10, 2023
@Frooodle
Copy link
Member

Done as part of v0.8.0 release. which is now live

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants