Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required attribute to input file #753

Closed
ProvaTeams opened this issue Jan 29, 2024 · 10 comments · Fixed by #755
Closed

Add required attribute to input file #753

ProvaTeams opened this issue Jan 29, 2024 · 10 comments · Fixed by #755
Assignees
Labels
enhancement New feature or request

Comments

@ProvaTeams
Copy link
Contributor

When submitting a form without a file now, the program returns different types of errors.
To correct this problem you can put the required attribute in fragments/common.html to avoid unnecessary requests to the API

@sbplat sbplat added the enhancement New feature or request label Jan 29, 2024
@sbplat
Copy link
Member

sbplat commented Jan 29, 2024

Would you like to work on this?

@ProvaTeams
Copy link
Contributor Author

I'm going to try, it's my first pull request

@sbplat
Copy link
Member

sbplat commented Jan 29, 2024

I've assigned this issue to you! If you have any questions, please feel free to ask.

@mannam11
Copy link
Contributor

@ProvaTeams do you have any screenshots or anything for better understanding on this issue

@ProvaTeams
Copy link
Contributor Author

Those are 2 different error on Split and Crop pages
SplitError
CropError

The possible solution would be something like this:
Solution

@mannam11
Copy link
Contributor

@sbplat I have fixed this issue. can you please review my PR.

@sbplat
Copy link
Member

sbplat commented Jan 31, 2024

Hi @mannam11! I appreciate your eagerness to work on issues, but could you request for the issue to be assigned to you before working on it? @ProvaTeams was assigned to this issue and has already opened a PR.

@mannam11
Copy link
Contributor

mannam11 commented Jan 31, 2024

I didn’t see any PR tagging to this issue so I opened a PR.
@sbplat How can I get this assigned to me..?

@sbplat
Copy link
Member

sbplat commented Jan 31, 2024

I didn’t see any PR tagging to this issue so I opened a PR.

The assignees list is on the right column.
image

@sbplat How can I get this assigned to me..?

Just ask! If nobody is already working on the issue, we will assign it to you.

@mannam11
Copy link
Contributor

Thanks for the information @sbplat

@sbplat sbplat linked a pull request Jan 31, 2024 that will close this issue
@sbplat sbplat closed this as completed Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants